All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Scharsig <js_at_ng@scharsoft.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH ATMEL REWORK] update arm/at91rm9200 work with rework rework110202
Date: Fri, 11 Feb 2011 18:36:49 +0100	[thread overview]
Message-ID: <4D5573B1.7050704@scharsoft.de> (raw)
In-Reply-To: <1DBE7A7C-2E1C-478A-A68F-CBA90EE629E4@googlemail.com>

Dear Andreas Bie?mann,

I'm offline for the net 10 days. So I fast include your comments to a V2 patch version

Am 11.02.2011 09:11, schrieb Andreas Bie?mann:
> Dear Jens Scharsig,
> 
> Am 10.02.2011 um 20:31 schrieb Jens Scharsig:
> 
>> * update arm920t/at91 to ATMEL_xxx name scheme
>> * convert at91rm9200ek and eb_cpux9k2 board to ATMEL_xxx name scheme
>> * update arm920t/at91 soc lib
>> * update at91_emac driver
>>
>> Signed-off-by: Jens Scharsig <js_at_ng@scharsoft.de>
> 
> Tested-by: Andreas Bie?mann <andreas.devel@gmail.com>
> 
> But some changes

I have prepare a second version of my patch.
> 
>> ---
>>
>> The eb_cpux9k2 board can compile and runs after patch changes
>> The at91rm9200ek can compile, but i have no hardware to test it.
> 
> at91rm9200ek is working but the change for timer.c is needed

The timer.c changes I sent i a previous patch. I have join them to V2
>  Testet peripheral for at91rm9200ek is:
>   - USB (fatls)
>   - EMAC (tftp)
> 
>>
>> +#define CONFIG_AT91FAMILY	/* it's a member of AT91 */
>> +#define CONFIG_ARM920T		/* This is an ARM920T Core	*/
>> +
> 
> These are defined in board header .. I saw they are defined also in other at91xxx.h files, we should discuss where to define these since all of the at91xx.h files are included by hardware.h

In V2 a have remove the define from board config's
> 
>> /* Periperial Identifiers */
> 
> [snip changes to at91rm9200.h which are obviously OK]
> 
>> +#define ATMEL_PIO_PORTS		4	/* theese SoCs have 3 PIO */
> 
> 3 or 4 PIO?

3 for PLCC and 4 for BGA variants. In PLCC the 4th port is not bound out. 
I set the comment to 4 in V2

>>
>> +
> 
> please remove this additional empty line

removed
> 
>> #define CONFIG_DRIVER_AT91EMAC		1
>> #define CONFIG_DRIVER_AT91EMAC_QUIET	1
>> +/*
>> +#define CONFIG_DRIVER_MACB		1
>> +*/
> 
> why this? Either it is needed or not.
> 
waste from testing, removed

Best regard 

Jens Scharsig

      reply	other threads:[~2011-02-11 17:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-10 19:31 [U-Boot] [PATCH ATMEL REWORK] update arm/at91rm9200 work with rework rework110202 Jens Scharsig
2011-02-11  8:11 ` Andreas Bießmann
2011-02-11 17:36   ` Jens Scharsig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5573B1.7050704@scharsoft.de \
    --to=js_at_ng@scharsoft.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.