All of lore.kernel.org
 help / color / mirror / Atom feed
From: Magnus Lilja <lilja.magnus@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] arm1136: Fix NAND boot
Date: Fri, 11 Feb 2011 19:58:36 +0100	[thread overview]
Message-ID: <4D5586DC.6010204@gmail.com> (raw)
In-Reply-To: <1297250276-16007-1-git-send-email-fabio.estevam@freescale.com>

Hi

I've tested Fabio's patch series and it makes the i.MX31 PDK boot nicely from NAND again. So from my point of view I
recommend to use these patches.


Best regards, Magnus

On 02/09/2011 12:17 PM, Fabio Estevam wrote:
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Signed-off-by: Magnus Lilja <lilja.magnus@gmail.com>
> ---
>  arch/arm/cpu/arm1136/start.S |   16 ++++------------
>  1 files changed, 4 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm1136/start.S b/arch/arm/cpu/arm1136/start.S
> index b771d31..bab2868 100644
> --- a/arch/arm/cpu/arm1136/start.S
> +++ b/arch/arm/cpu/arm1136/start.S
> @@ -163,15 +163,7 @@ call_board_init_f:
>  	bic	sp, sp, #7 /* 8-byte alignment for ABI compliance */
>  	ldr	r0,=0x00000000
>  
> -#ifdef CONFIG_NAND_SPL
> -	bl	nand_boot
> -#else
> -#ifdef CONFIG_ONENAND_IPL
> -	bl	start_oneboot
> -#else
>  	bl	board_init_f
> -#endif /* CONFIG_ONENAND_IPL */
> -#endif /* CONFIG_NAND_SPL */
>  
>  /*------------------------------------------------------------------------------*/
>  
> @@ -267,10 +259,10 @@ clbss_l:str	r2, [r0]		/* clear loop...		    */
>   */
>  #ifdef CONFIG_NAND_SPL
>  	ldr     r0, _nand_boot_ofs
> -	adr	r1, _start
> -	add	pc, r0, r1
> -_nand_boot_ofs
> -	: .word nand_boot - _start
> +	mov	pc, r0
> +
> +_nand_boot_ofs:
> +	.word nand_boot
>  #else
>  jump_2_ram:
>  	ldr	r0, _board_init_r_ofs

  parent reply	other threads:[~2011-02-11 18:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09 11:17 [U-Boot] [PATCH 1/3] arm1136: Fix NAND boot Fabio Estevam
2011-02-09 11:17 ` [U-Boot] [PATCH 2/3] mx31pdk: Use the new relocation scheme Fabio Estevam
2011-02-09 11:17   ` [U-Boot] [PATCH 3/3] mx31pdk: Make the full boot log visible Fabio Estevam
2011-02-13  9:53     ` Stefano Babic
2011-02-13  9:52   ` [U-Boot] [PATCH 2/3] mx31pdk: Use the new relocation scheme Stefano Babic
2011-02-11 18:58 ` Magnus Lilja [this message]
2011-02-12  7:07   ` [U-Boot] [PATCH 1/3] arm1136: Fix NAND boot Albert ARIBAUD
2011-02-13 14:43     ` Magnus Lilja
2011-02-16 11:58       ` Fabio Estevam
2011-02-17 20:43         ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5586DC.6010204@gmail.com \
    --to=lilja.magnus@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.