Problem with makedevs

Problem with makedevs

[Filip Zyzniewski]

Hi,

I think there is a problem with makedevs scripts. When I build
bootstrap-image for jlime-2010.1.conf, the makedevs binary is a
symlink to busybox.

During bootup it complains about the way it's called from /etc/init.d/devices:

/sbin/makedevs -r / -D /etc/device_table

The proper way for this binary is:

/sbin/makedevs -d /etc/device_table /

It surprises me that nobody has noticed this before - is my
configuration somehow unique? Jlime config file isn't overriding much
here...

What is a proper fix for this?

bye,
Filip Zyzniewski

Re: Problem with makedevs

[Andrea Adami]

On Wed, Feb 9, 2011 at 10:54 PM, Filip Zyzniewski
<filip.zyzniewski@gmail.com> wrote:
> Hi,
>
> I think there is a problem with makedevs scripts. When I build
> bootstrap-image for jlime-2010.1.conf, the makedevs binary is a
> symlink to busybox.
>
> During bootup it complains about the way it's called from /etc/init.d/devices:
>
> /sbin/makedevs -r / -D /etc/device_table
>
> The proper way for this binary is:
>
> /sbin/makedevs -d /etc/device_table /
>
> It surprises me that nobody has noticed this before - is my
> configuration somehow unique? Jlime config file isn't overriding much
> here...
>
> What is a proper fix for this?
>
> bye,
> Filip Zyzniewski
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Filip,

reading your post I remember now I had a related issue creating initramfs:

[20100624 00:31:46]	<ant___>  	in the rootfs of myimages there is any
/dev/input/event, even though is listed in device-tables-minimal
[20100624 00:32:21]	<ant___>  	I mean before launching udev
[20100624 00:32:37]	<ant___>  	or in my case in an initramfs
[20100624 00:33:02]	<ant___>  	seems an issue with makedevs

[20100624 00:35:42]	<ant___>  	the command in image.bbclass is:
makedevs -r ${IMAGE_ROOTFS} -D $devtable
[20100624 01:09:38]	<ant___>  	I fear makedevs.c cannot create files in subdirs
[20100624 01:11:04]	<ant___>  	there is more: initscripts have their
device-table :(

FYI see related http://bugs.openembedded.net/show_bug.cgi?id=3593


[20100624 01:16:10]	<ant___>  	too late now to inspect makedevs.c
[20100624 01:16:33]	<ant___>  	perhaps tomorrow

...and then I forgot and moved to other things :/
(For our initramfs-kexecboot image, we solved drastically deleting and
recreating the devices one by one with mknod.)

So, yes, maybe it's a new syntax.
I'll test asap.

Regards
Andrea

[PATCH] initscripts: handle busybox version of makedevs properly.

[Filip Zyzniewski]

Makedevs from busybox has a different command line syntax.

Signed-off-by: Filip Zyzniewski <filip.zyzniewski@gmail.com>
---
 recipes/initscripts/initscripts-1.0/devices |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/recipes/initscripts/initscripts-1.0/devices b/recipes/initscripts/initscripts-1.0/devices
index 67a2ec8..4059628 100755
--- a/recipes/initscripts/initscripts-1.0/devices
+++ b/recipes/initscripts/initscripts-1.0/devices
@@ -56,7 +56,13 @@ else
 	done
 	ln -sf /proc/self/fd /dev/fd
 	ln -sf /proc/kcore /dev/core
-	/sbin/makedevs -r / -D /etc/device_table
+
+	if test `readlink -f "/sbin/makedevs"` = "/bin/busybox"; then
+		MAKEDEV_ARGS="-d /etc/device_table /"
+	else
+		MAKEDEV_ARGS="-r / -D /etc/device_table"
+	fi
+	/sbin/makedevs $MAKEDEV_ARGS
 	if test $? -ne 0; then
 		if test "$VERBOSE" != "no"; then echo "failed"; fi
 	else
-- 
1.7.1

Re: [PATCH] initscripts: handle busybox version of makedevs properly.

[Tom Rini]

On 02/11/2011 11:06 AM, Filip Zyzniewski wrote:
> Makedevs from busybox has a different command line syntax.
>
> Signed-off-by: Filip Zyzniewski<filip.zyzniewski@gmail.com>
> ---
>   recipes/initscripts/initscripts-1.0/devices |    8 +++++++-
>   1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/initscripts/initscripts-1.0/devices b/recipes/initscripts/initscripts-1.0/devices
> index 67a2ec8..4059628 100755
> --- a/recipes/initscripts/initscripts-1.0/devices
> +++ b/recipes/initscripts/initscripts-1.0/devices
> @@ -56,7 +56,13 @@ else
>   	done
>   	ln -sf /proc/self/fd /dev/fd
>   	ln -sf /proc/kcore /dev/core
> -	/sbin/makedevs -r / -D /etc/device_table
> +
> +	if test `readlink -f "/sbin/makedevs"` = "/bin/busybox"; then
> +		MAKEDEV_ARGS="-d /etc/device_table /"
> +	else
> +		MAKEDEV_ARGS="-r / -D /etc/device_table"
> +	fi
> +	/sbin/makedevs $MAKEDEV_ARGS
>   	if test $? -ne 0; then
>   		if test "$VERBOSE" != "no"; then echo "failed"; fi
>   	else

Is there a syntax that works for both?

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH] initscripts: handle busybox version of makedevs properly.

[Filip Zyzniewski]

On 2/11/11, Tom Rini <tom_rini@mentor.com> wrote:

> Is there a syntax that works for both?

I've looked at the source code of both versions and there is no
compatible syntax.

bye,
Filip Zyzniewski

Re: [PATCH] initscripts: handle busybox version of makedevs properly.

[Tom Rini]

On 02/11/2011 11:06 AM, Filip Zyzniewski wrote:
> Makedevs from busybox has a different command line syntax.
>
> Signed-off-by: Filip Zyzniewski<filip.zyzniewski@gmail.com>
> ---
>   recipes/initscripts/initscripts-1.0/devices |    8 +++++++-
>   1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/initscripts/initscripts-1.0/devices b/recipes/initscripts/initscripts-1.0/devices
> index 67a2ec8..4059628 100755
> --- a/recipes/initscripts/initscripts-1.0/devices
> +++ b/recipes/initscripts/initscripts-1.0/devices
> @@ -56,7 +56,13 @@ else
>   	done
>   	ln -sf /proc/self/fd /dev/fd
>   	ln -sf /proc/kcore /dev/core
> -	/sbin/makedevs -r / -D /etc/device_table
> +
> +	if test `readlink -f "/sbin/makedevs"` = "/bin/busybox"; then
> +		MAKEDEV_ARGS="-d /etc/device_table /"
> +	else
> +		MAKEDEV_ARGS="-r / -D /etc/device_table"
> +	fi
> +	/sbin/makedevs $MAKEDEV_ARGS
>   	if test $? -ne 0; then
>   		if test "$VERBOSE" != "no"; then echo "failed"; fi
>   	else

Thanks for digging into this, applied.

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH] initscripts: handle busybox version of makedevs properly.

[Mike Westerhof]

On 2/11/2011 3:10 PM, Filip Zyzniewski wrote:
> On 2/11/11, Tom Rini <tom_rini@mentor.com> wrote:
> 
>> Is there a syntax that works for both?
> 
> I've looked at the source code of both versions and there is no
> compatible syntax.

Hmmm... perhaps this means that the more correct fix would be to create
a patch for busybox that would bring it into line with the syntax of the
real application?

-Mike (mwester)

Re: [PATCH] initscripts: handle busybox version of makedevs properly.

[Filip Zyzniewski]

On 2/11/11, Mike Westerhof <mike@mwester.net> wrote:

> Hmmm... perhaps this means that the more correct fix would be to create
> a patch for busybox that would bring it into line with the syntax of the
> real application?

Or the other way around - it could be simpler for us as makedevs.c is
in the OE tree.
I didn't want to stir up things too much, so I chose the 'safer' way.

I did it similarly to the way it's done in
recipes/slugos-init/files/turnup.

bye,
Filip Zyzniewski