All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Molton <ian.molton@collabora.co.uk>
To: Paul Mackerras <paulus@samba.org>
Cc: netdev@vger.kernel.org, rdunlap@xenotime.net,
	isdn@linux-pingi.de, arnd@arndb.de, davem@davemloft.net,
	herbert@gondor.apana.org.au, ebiederm@xmission.com
Subject: Re: [RFD][PATCH] Add JMEMCMP to Berkeley Packet Filters
Date: Sat, 12 Feb 2011 12:47:40 +0000	[thread overview]
Message-ID: <4D56816C.9070006@collabora.co.uk> (raw)
In-Reply-To: <20110212021441.GA3035@sammy.paulus.ozlabs.org>

On 12/02/11 02:14, Paul Mackerras wrote:
> On Thu, Feb 10, 2011 at 12:14:46PM +0000, Ian Molton wrote:
>
>> This patch implements an extension for BPF to allow filter programs to use a
>> data section, along with a MEMCMP instruction.
>>
>> There are a few issues noted in the patch itself, which can easily be
>> addressed, and I would like to check wether sk_run_filter is ever expected to
>> be called from a context that cannot sleep (I dont think it is).
>
> The ppp driver (ppp_generic.c) calls sk_run_filter inside a region
> protected by spin_lock_bh, so we can't sleep there.  Having sk_run_filter
> potentially sleep would make it useless for ppp.

Thanks for the review.

I'll fix it not to sleep :)

Do I take it from the lack of people comlpaining that the concept of 
adding this type of instruction itself is not a problem ?

Thanks!

-Ian

  reply	other threads:[~2011-02-12 12:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-10 12:14 [RFD][PATCH] Add JMEMCMP to Berkeley Packet Filters Ian Molton
2011-02-10 12:57 ` Ian Molton
2011-02-12  2:14 ` Paul Mackerras
2011-02-12 12:47   ` Ian Molton [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-02-10 12:31 Ian Molton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D56816C.9070006@collabora.co.uk \
    --to=ian.molton@collabora.co.uk \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=isdn@linux-pingi.de \
    --cc=netdev@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.