From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39282 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PowWV-0004C6-NT for qemu-devel@nongnu.org; Mon, 14 Feb 2011 06:23:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PowWG-0001fZ-EA for qemu-devel@nongnu.org; Mon, 14 Feb 2011 06:23:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PowWG-0001fB-0G for qemu-devel@nongnu.org; Mon, 14 Feb 2011 06:23:04 -0500 Message-ID: <4D591085.9020906@redhat.com> Date: Mon, 14 Feb 2011 12:22:45 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1297121191-31245-1-git-send-email-agraf@suse.de> In-Reply-To: <1297121191-31245-1-git-send-email-agraf@suse.de> Content-Type: multipart/mixed; boundary="------------020007010403000305020901" Subject: [Qemu-devel] Re: [RFC] prep: enable irq sharing on ide again List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Kevin Wolf , =?UTF-8?B?cg==?= , QEMU Developers , Aurelien Jarno , =?UTF-8?B?QW5kcmVhcyBGw6RyYmU=?=@gnu.org This is a multi-part message in MIME format. --------------020007010403000305020901 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/08/11 00:26, Alexander Graf wrote: > The new ISA infrastructure checks for potential irq sharing bugs on > interrupt lines, because usually irq lines on isa can't be shared. > > The PREP spec however mandates that the irq lines for both IDE ports > are shared and according to Aurelien this also used to work just fine. > > So let's add a way to enable this sharing again, so we don't introduce > unnecessary regressions over older versions of Qemu. Had a patch for that, got shoot down for reasons I don't remember, attached for reference. It basically allows IRQ sharing in case the two devices sharing the IRQ are of the same kind. In that case you usually have a single guest driver handling both devices and IRQ sharing works most of the time. I don't mind much which approach we take ... cheers, Gerd --------------020007010403000305020901 Content-Type: text/plain; name="0001-isa-refine-irq-reservations.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-isa-refine-irq-reservations.patch" RnJvbSA0NGQ3YjU5ZWU5Y2M4YTU3ZTk5OTlhN2I2ZWNkZjUzNzk4ZDJjNzRkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNv bT4KRGF0ZTogRnJpLCAxMSBTZXAgMjAwOSAxMzo0Mzo0NiArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIGlzYTogcmVmaW5lIGlycSByZXNlcnZhdGlvbnMKClRoZXJlIGFyZSBhIGZldyBjYXNl cyB3aGVyZSBJUlEgc2hhcmluZyBvbiB0aGUgSVNBIGJ1cyBpcyB1c2VkIGFuZApwb3NzaWJs ZS4gIEluIGdlbmVyYWwgb25seSBkZXZpY2VzIG9mIHRoZSBzYW1lIGtpbmQgY2FuIGRvIHRo YXQuCkEgZmV3IHVzZSBjYXNlczoKCiAgKiBzZXJpYWwgbGluZXMgMSszIHNoYXJlIGlycSA0 CiAgKiBzZXJpYWwgbGluZXMgMis0IHNoYXJlIGlycSAzCiAgKiBwYXJhbGxlbCBwb3J0cyBz aGFyZSBpcnEgNwogICogcHBjL3ByZXA6IGlkZSBwb3J0cyBzaGFyZSBpcnEgMTMKClRoaXMg cGF0Y2ggcmVmaW5lcyB0aGUgaXJxIHJlc2VydmF0aW9uIG1lY2hhbmlzbSBmb3IgdGhlIGlz YSBidXMgdG8KaGFuZGxlIHRob3NlIGNhc2VzLiAgSXQga2VlcHMgdHJhY2sgb2YgdGhlIGRy aXZlciB3aGljaCBvd25zIHRoZSBJUlEgaW4KcXVlc3Rpb24gYW5kIGFsbG93cyBpcnEgc2hh cmluZyBmb3IgZGV2aWNlcyBoYW5kbGVkIGJ5IHRoZSBzYW1lIGRyaXZlci4KClNpZ25lZC1v ZmYtYnk6IEdlcmQgSG9mZm1hbm4gPGtyYXhlbEByZWRoYXQuY29tPgotLS0KIGh3L2lzYS1i dXMuYyB8ICAgMTYgKysrKysrKysrKysrKy0tLQogMSBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2h3L2lzYS1idXMuYyBi L2h3L2lzYS1idXMuYwppbmRleCA0ZTMwNmRlLi5hOTllNzkzIDEwMDY0NAotLS0gYS9ody9p c2EtYnVzLmMKKysrIGIvaHcvaXNhLWJ1cy5jCkBAIC0yNiw2ICsyNiw3IEBAIHN0cnVjdCBJ U0FCdXMgewogICAgIEJ1c1N0YXRlIHFidXM7CiAgICAgcWVtdV9pcnEgKmlycXM7CiAgICAg dWludDMyX3QgYXNzaWduZWQ7CisgICAgRGV2aWNlSW5mbyAqaXJxX293bmVyWzE2XTsKIH07 CiBzdGF0aWMgSVNBQnVzICppc2FidXM7CiB0YXJnZXRfcGh5c19hZGRyX3QgaXNhX21lbV9i YXNlID0gMDsKQEAgLTcyLDcgKzczLDkgQEAgcWVtdV9pcnEgaXNhX3Jlc2VydmVfaXJxKGlu dCBpc2FpcnEpCiAgICAgICAgIGV4aXQoMSk7CiAgICAgfQogICAgIGlmIChpc2FidXMtPmFz c2lnbmVkICYgKDEgPDwgaXNhaXJxKSkgewotICAgICAgICBmcHJpbnRmKHN0ZGVyciwgImlz YSBpcnEgJWQgYWxyZWFkeSBhc3NpZ25lZFxuIiwgaXNhaXJxKTsKKyAgICAgICAgRGV2aWNl SW5mbyAqb3duZXIgPSBpc2FidXMtPmlycV9vd25lcltpc2FpcnFdOworICAgICAgICBmcHJp bnRmKHN0ZGVyciwgImlzYSBpcnEgJWQgYWxyZWFkeSBhc3NpZ25lZCAoJXMpXG4iLAorICAg ICAgICAgICAgICAgIGlzYWlycSwgb3duZXIgPyBvd25lci0+bmFtZSA6ICJ1bmtub3duIik7 CiAgICAgICAgIGV4aXQoMSk7CiAgICAgfQogICAgIGlzYWJ1cy0+YXNzaWduZWQgfD0gKDEg PDwgaXNhaXJxKTsKQEAgLTgzLDEwICs4NiwxNyBAQCB2b2lkIGlzYV9pbml0X2lycShJU0FE ZXZpY2UgKmRldiwgcWVtdV9pcnEgKnAsIGludCBpc2FpcnEpCiB7CiAgICAgYXNzZXJ0KGRl di0+bmlycXMgPCBBUlJBWV9TSVpFKGRldi0+aXNhaXJxKSk7CiAgICAgaWYgKGlzYWJ1cy0+ YXNzaWduZWQgJiAoMSA8PCBpc2FpcnEpKSB7Ci0gICAgICAgIGZwcmludGYoc3RkZXJyLCAi aXNhIGlycSAlZCBhbHJlYWR5IGFzc2lnbmVkXG4iLCBpc2FpcnEpOwotICAgICAgICBleGl0 KDEpOworICAgICAgICBEZXZpY2VJbmZvICpvd25lciA9IGlzYWJ1cy0+aXJxX293bmVyW2lz YWlycV07CisgICAgICAgIGlmIChvd25lciA9PSBkZXYtPnFkZXYuaW5mbykgeworICAgICAg ICAgICAgLyogaXJxIHNoYXJpbmcgaXMgb2sgaW4gY2FzZSB0aGUgc2FtZSBkcml2ZXIgaGFu ZGxlcyBib3RoICovOworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgZnByaW50Zihz dGRlcnIsICJpc2EgaXJxICVkIGFscmVhZHkgYXNzaWduZWQgKCVzKVxuIiwKKyAgICAgICAg ICAgICAgICAgICAgaXNhaXJxLCBvd25lciA/IG93bmVyLT5uYW1lIDogInVua25vd24iKTsK KyAgICAgICAgICAgIGV4aXQoMSk7CisgICAgICAgIH0KICAgICB9CiAgICAgaXNhYnVzLT5h c3NpZ25lZCB8PSAoMSA8PCBpc2FpcnEpOworICAgIGlzYWJ1cy0+aXJxX293bmVyW2lzYWly cV0gPSBkZXYtPnFkZXYuaW5mbzsKICAgICBkZXYtPmlzYWlycVtkZXYtPm5pcnFzXSA9IGlz YWlycTsKICAgICAqcCA9IGlzYWJ1cy0+aXJxc1tpc2FpcnFdOwogICAgIGRldi0+bmlycXMr KzsKLS0gCjEuNy4xCgo= --------------020007010403000305020901--