All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Patrick McHardy <kaber@trash.net>,
	netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
	coreteam@netfilter.org, Patrick McHardy <kaber@trash.net>
Cc: stefanb@linux.vnet.ibm.com
Subject: [PATCH] [connlimit] Revert 44bd4de9
Date: Mon, 14 Feb 2011 10:30:21 -0500	[thread overview]
Message-ID: <4D594A8D.5040600@linux.vnet.ibm.com> (raw)

I have to revert the early loop termination in connlimit since it 
generates problems when an iptables statement does not use -m state 
--state NEW before the connlimit match extension.

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

---
  net/netfilter/xt_connlimit.c |   13 +++----------
  1 file changed, 3 insertions(+), 10 deletions(-)

Index: nf-next-2.6/net/netfilter/xt_connlimit.c
===================================================================
--- nf-next-2.6.orig/net/netfilter/xt_connlimit.c
+++ nf-next-2.6/net/netfilter/xt_connlimit.c
@@ -97,8 +97,7 @@ static int count_them(struct net *net,
                const struct nf_conntrack_tuple *tuple,
                const union nf_inet_addr *addr,
                const union nf_inet_addr *mask,
-              u_int8_t family,
-              unsigned int threshold)
+              u_int8_t family)
  {
      const struct nf_conntrack_tuple_hash *found;
      struct xt_connlimit_conn *conn;
@@ -152,14 +151,9 @@ static int count_them(struct net *net,
              continue;
          }

-        if (same_source_net(addr, mask, &conn->tuple.src.u3, family)) {
+        if (same_source_net(addr, mask, &conn->tuple.src.u3, family))
              /* same source network -> be counted! */
              ++matches;
-            if (matches > threshold) {
-                nf_ct_put(found_ct);
-                break;
-            }
-        }
          nf_ct_put(found_ct);
      }

@@ -213,8 +207,7 @@ connlimit_mt(const struct sk_buff *skb,

      spin_lock_bh(&info->data->lock);
      connections = count_them(net, info->data, tuple_ptr, &addr,
- &info->mask, par->family,
-                             info->limit);
+ &info->mask, par->family);
      spin_unlock_bh(&info->data->lock);

      if (connections < 0)

             reply	other threads:[~2011-02-14 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14 15:30 Stefan Berger [this message]
2011-02-14 15:45 ` [PATCH] [connlimit] Revert 44bd4de9 Jan Engelhardt
2011-02-14 16:01   ` Patrick McHardy
2011-02-14 15:58 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D594A8D.5040600@linux.vnet.ibm.com \
    --to=stefanb@linux.vnet.ibm.com \
    --cc=coreteam@netfilter.org \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.