diff for duplicates of <4D59DA29.6070501@bluewatersys.com> diff --git a/a/1.txt b/N1/1.txt index 8fc9f01..79ee6b3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -8,7 +8,7 @@ On 02/15/2011 02:36 PM, Jeremy Kerr wrote: >>> + >>> + spin_lock_irqsave(&clk->enable_lock, flags); >> ->> WARN_ON(clk->prepare_count = 0); ? +>> WARN_ON(clk->prepare_count == 0); ? > > Added later, but yes. @@ -16,7 +16,7 @@ Okay, but still failing to understand why this isn't it the first patch. You are introducing a new file after all. >> ->>> + if (clk->enable_count = 0 && clk->ops->enable) +>>> + if (clk->enable_count == 0 && clk->ops->enable) >>> + ret = clk->ops->enable(clk); >> >> Does it make sense to have a clock with no enable function which still @@ -84,7 +84,7 @@ from anywhere except clkdev.c. Bluewater Systems Ltd - ARM Technology Solution Centre Ryan Mallon 5 Amuri Park, 404 Barbadoes St -ryan@bluewatersys.com PO Box 13 889, Christchurch 8013 +ryan at bluewatersys.com PO Box 13 889, Christchurch 8013 http://www.bluewatersys.com New Zealand Phone: +64 3 3779127 Freecall: Australia 1800 148 751 Fax: +64 3 3779135 USA 1800 261 2934 diff --git a/a/content_digest b/N1/content_digest index f30a80d..410acbc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,9 @@ "ref\01297233693.242364.862698430999.1.gpush@pororo\0" "ref\04D52F73A.4010707@bluewatersys.com\0" "ref\0201102150936.26110.jeremy.kerr@canonical.com\0" - "From\0Ryan Mallon <ryan@bluewatersys.com>\0" - "Subject\0Re: [RFC,PATCH 1/3] Add a common struct clk\0" - "Date\0Tue, 15 Feb 2011 01:43:05 +0000\0" + "From\0ryan@bluewatersys.com (Ryan Mallon)\0" + "Subject\0[RFC,PATCH 1/3] Add a common struct clk\0" + "Date\0Tue, 15 Feb 2011 14:43:05 +1300\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -17,7 +17,7 @@ ">>> +\n" ">>> +\tspin_lock_irqsave(&clk->enable_lock, flags);\n" ">>\n" - ">> \tWARN_ON(clk->prepare_count = 0); ?\n" + ">> \tWARN_ON(clk->prepare_count == 0); ?\n" "> \n" "> Added later, but yes.\n" "\n" @@ -25,7 +25,7 @@ "You are introducing a new file after all.\n" "\n" ">>\n" - ">>> +\tif (clk->enable_count = 0 && clk->ops->enable)\n" + ">>> +\tif (clk->enable_count == 0 && clk->ops->enable)\n" ">>> +\t\tret = clk->ops->enable(clk);\n" ">>\n" ">> Does it make sense to have a clock with no enable function which still\n" @@ -93,9 +93,9 @@ "Bluewater Systems Ltd - ARM Technology Solution Centre\n" "\n" "Ryan Mallon \t\t5 Amuri Park, 404 Barbadoes St\n" - "ryan@bluewatersys.com \tPO Box 13 889, Christchurch 8013\n" + "ryan at bluewatersys.com \tPO Box 13 889, Christchurch 8013\n" "http://www.bluewatersys.com\tNew Zealand\n" "Phone: +64 3 3779127\t\tFreecall: Australia 1800 148 751\n" "Fax: +64 3 3779135\t\t\t USA 1800 261 2934" -d060a646128fbb785fdd05b7bf20417e9ff6e3fa6ae2ff1e10e0fd1a08d07d3a +0a79d33cebff0e4a5aa48e094b13b33be07515b61a0788809540db37b7e9652b
diff --git a/a/1.txt b/N2/1.txt index 8fc9f01..a2f62cf 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -8,7 +8,7 @@ On 02/15/2011 02:36 PM, Jeremy Kerr wrote: >>> + >>> + spin_lock_irqsave(&clk->enable_lock, flags); >> ->> WARN_ON(clk->prepare_count = 0); ? +>> WARN_ON(clk->prepare_count == 0); ? > > Added later, but yes. @@ -16,7 +16,7 @@ Okay, but still failing to understand why this isn't it the first patch. You are introducing a new file after all. >> ->>> + if (clk->enable_count = 0 && clk->ops->enable) +>>> + if (clk->enable_count == 0 && clk->ops->enable) >>> + ret = clk->ops->enable(clk); >> >> Does it make sense to have a clock with no enable function which still diff --git a/a/content_digest b/N2/content_digest index f30a80d..37bffbc 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,8 +3,22 @@ "ref\0201102150936.26110.jeremy.kerr@canonical.com\0" "From\0Ryan Mallon <ryan@bluewatersys.com>\0" "Subject\0Re: [RFC,PATCH 1/3] Add a common struct clk\0" - "Date\0Tue, 15 Feb 2011 01:43:05 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Tue, 15 Feb 2011 14:43:05 +1300\0" + "To\0Jeremy Kerr <jeremy.kerr@canonical.com>\0" + "Cc\0linux-arm-kernel@lists.infradead.org" + Nicolas Pitre <nicolas.pitre@linaro.org> + Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com> + Vincent Guittot <vincent.guittot@linaro.org> + linux-sh@vger.kernel.org + Ben Herrenschmidt <benh@kernel.crashing.org> + Sascha Hauer <s.hauer@pengutronix.de> + Paul Mundt <lethal@linux-sh.org> + linux-kernel@vger.kernel.org + Dima Zavin <dmitriyz@google.com> + Saravana Kannan <skannan@codeaurora.org> + Ben Dooks <ben-linux@fluff.org> + " Uwe Kleine-K\303\266nig <u.kleine-koenig@pengutronix.de>" + " Russell King <linux@arm.linux.org.uk>\0" "\00:1\0" "b\0" "On 02/15/2011 02:36 PM, Jeremy Kerr wrote:\n" @@ -17,7 +31,7 @@ ">>> +\n" ">>> +\tspin_lock_irqsave(&clk->enable_lock, flags);\n" ">>\n" - ">> \tWARN_ON(clk->prepare_count = 0); ?\n" + ">> \tWARN_ON(clk->prepare_count == 0); ?\n" "> \n" "> Added later, but yes.\n" "\n" @@ -25,7 +39,7 @@ "You are introducing a new file after all.\n" "\n" ">>\n" - ">>> +\tif (clk->enable_count = 0 && clk->ops->enable)\n" + ">>> +\tif (clk->enable_count == 0 && clk->ops->enable)\n" ">>> +\t\tret = clk->ops->enable(clk);\n" ">>\n" ">> Does it make sense to have a clock with no enable function which still\n" @@ -98,4 +112,4 @@ "Phone: +64 3 3779127\t\tFreecall: Australia 1800 148 751\n" "Fax: +64 3 3779135\t\t\t USA 1800 261 2934" -d060a646128fbb785fdd05b7bf20417e9ff6e3fa6ae2ff1e10e0fd1a08d07d3a +75ec1df30797bced03359dee236b186630dc8f8738d8dc6aa3087e12ec40a625
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.