From: Jiri Slaby <jirislaby@gmail.com>
To: wei_wang@realsil.com.cn
Cc: gregkh@suse.de, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb_storage: realtek_cr patch: fix sparse warning
Date: Tue, 15 Feb 2011 09:50:50 +0100 [thread overview]
Message-ID: <4D5A3E6A.6020800@gmail.com> (raw)
In-Reply-To: <1297733911-24267-1-git-send-email-wei_wang@realsil.com.cn>
On 02/15/2011 02:38 AM, wei_wang@realsil.com.cn wrote:
> From: wwang <wei_wang@realsil.com.cn>
>
> Fix some sparse warning for realtek_cr patch
>
> Signed-off-by: wwang <wei_wang@realsil.com.cn>
> ---
> drivers/usb/storage/realtek_cr.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
> index c2bebb3..4f6b25f 100644
> --- a/drivers/usb/storage/realtek_cr.c
> +++ b/drivers/usb/storage/realtek_cr.c
> @@ -141,7 +141,7 @@ static int init_realtek_cr(struct us_data *us);
> .driver_info = (flags)|(USB_US_TYPE_STOR<<24)\
> }
>
> -struct usb_device_id realtek_cr_ids[] = {
> +static struct usb_device_id realtek_cr_ids[] = {
And it may be const too while you are at it...
regards,
--
js
prev parent reply other threads:[~2011-02-15 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 1:38 [PATCH] usb_storage: realtek_cr patch: fix sparse warning wei_wang
2011-02-15 8:50 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5A3E6A.6020800@gmail.com \
--to=jirislaby@gmail.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.