From: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
To: balbi@ti.com
Cc: Thomas Weber <weber@corscience.de>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-omap@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Hans Verkuil <hverkuil@xs4all.nl>, Tejun Heo <tj@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] video: omap24xxcam: Fix compilation
Date: Tue, 15 Feb 2011 14:17:48 +0200 [thread overview]
Message-ID: <4D5A6EEC.5000908@maxwell.research.nokia.com> (raw)
In-Reply-To: <20110215115349.GQ2570@legolas.emea.dhcp.ti.com>
Felipe Balbi wrote:
> Hi,
>
> On Tue, Feb 15, 2011 at 12:50:12PM +0100, Thomas Weber wrote:
>> Hello Felipe,
>>
>> in include/linux/wait.h
>>
>> #define wake_up(x) __wake_up(x, TASK_NORMAL, 1, NULL)
>
> aha, now I get it, so shouldn't the real fix be including <linux/sched.h>
> on <linux/wait.h>, I mean, it's <linuux/wait.h> who uses a symbol
> defined in <linux/sched.h>, right ?
Surprisingly many other files still don't seem to be affected. But this
is actually a better solution (to include sched.h in wait.h).
--
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com
next prev parent reply other threads:[~2011-02-15 12:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 8:49 [PATCH resend] video: omap24xxcam: Fix compilation Thomas Weber
2011-02-07 16:15 ` Randy Dunlap
2011-02-15 11:28 ` Sakari Ailus
2011-02-15 11:37 ` Felipe Balbi
2011-02-15 11:44 ` Sylwester Nawrocki
2011-02-15 11:47 ` Felipe Balbi
2011-02-15 11:49 ` Sakari Ailus
2011-02-15 11:50 ` Thomas Weber
2011-02-15 11:53 ` Felipe Balbi
2011-02-15 12:17 ` Sakari Ailus [this message]
2011-02-19 11:35 ` David Cohen
2011-02-19 15:00 ` Felipe Balbi
2011-02-19 16:04 ` David Cohen
2011-02-21 7:36 ` Felipe Balbi
2011-02-21 12:09 ` David Cohen
2011-02-21 12:21 ` Felipe Balbi
2011-02-24 23:36 ` David Cohen
2011-02-25 6:59 ` Thomas Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5A6EEC.5000908@maxwell.research.nokia.com \
--to=sakari.ailus@maxwell.research.nokia.com \
--cc=balbi@ti.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=s.nawrocki@samsung.com \
--cc=tj@kernel.org \
--cc=weber@corscience.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.