All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Nikolay Ledovskikh <nledovskikh@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	lrodriguez@atheros.com, mickflemm@gmail.com, me@bobcopeland.com
Subject: Re: [PATCH] ath5k: Right channel setting for ar2317 chip
Date: Tue, 15 Feb 2011 20:42:50 +0100	[thread overview]
Message-ID: <4D5AD73A.70909@gmail.com> (raw)
In-Reply-To: <20110215221313.498d21ed.nledovskikh@gmail.com>

On 02/15/2011 08:13 PM, Nikolay Ledovskikh wrote:
> Patch that fixes right channel setting when running ar2317 based boards.

I see what it does. However I want to know why. That's what the
changelog should enlighten. I suppose we didn't handled ar2317 and we
want to. And since it is the same as 2425 we may reuse the current code?

> Signed-off-by: Nikolay Ledovskikh <nledovskikh@gmail.com>
> ---
> diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
> index 78c26fd..c44111f 100644
> --- a/drivers/net/wireless/ath/ath5k/phy.c
> +++ b/drivers/net/wireless/ath/ath5k/phy.c
> @@ -1253,6 +1253,7 @@ static int ath5k_hw_channel(struct ath5k_hw *ah,
>  	case AR5K_RF5111:
>  		ret = ath5k_hw_rf5111_channel(ah, channel);
>  		break;
> +	case AR5K_RF2317:
>  	case AR5K_RF2425:
>  		ret = ath5k_hw_rf2425_channel(ah, channel);
>  		break;
> 


-- 
js

  reply	other threads:[~2011-02-15 19:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-15 19:13 [PATCH] ath5k: Right channel setting for ar2317 chip Nikolay Ledovskikh
2011-02-15 19:42 ` Jiri Slaby [this message]
2011-02-15 20:51   ` Nikolay Ledovskikh
2011-02-17  0:38 ` Nick Kossifidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5AD73A.70909@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    --cc=me@bobcopeland.com \
    --cc=mickflemm@gmail.com \
    --cc=nledovskikh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.