All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier Guiter <olivier.guiter@linux.intel.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] gprs:Add code to handle AT+CGDCONT
Date: Wed, 16 Feb 2011 09:30:19 +0100	[thread overview]
Message-ID: <4D5B8B1B.7000200@linux.intel.com> (raw)
In-Reply-To: <1297839016.2519.14.camel@aeonflux>

[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]

Hi Denis and Marcel,

> Hi Denis,
>
>>> ---
>>>   include/gprs.h |    2 +
>>>   src/gprs.c     |   63 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>   2 files changed, 65 insertions(+), 0 deletions(-)
>> So I went in a slightly different direction with the emulator API.  Can
>> you please have a look?
>>
>> Also, I'd really rather hold off trying to implement CGDCONT right now.
>>   That piece is quite nasty and generally of lower priority.  I'd like to
>> get the emulator a bit more hashed out first and implement the base BT
>> DUN&  BT HFP profiles.
> for the sake of testing, I would be fine with the real basic CGDCONT and
> just offering IP and CID 1. And then of course accepting any APN in that
> range and rejecting any other command.
The submitted code is just an "how-to", and need to be updated to 
implement the complete CGDCONT (up to now, the function displays the 
existings contexts, and the default range values.
The idea behind this code was to provide the complete chain to handle AT 
commands in atoms. I m not sure the current handler mechanism fit with 
Denis's view ;)
Regards,
Olivier

  reply	other threads:[~2011-02-16  8:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-15 13:19 [PATCH 0/2] Add AT commands handler in emulator Olivier Guiter
2011-02-15 13:19 ` [PATCH 1/2] gprs:Add code to handle AT+CGDCONT Olivier Guiter
2011-02-16  6:32   ` Denis Kenzior
2011-02-16  6:50     ` Marcel Holtmann
2011-02-16  8:30       ` Olivier Guiter [this message]
2011-02-15 13:19 ` [PATCH 2/2] emulator: Add +CGMI and +CGDCONT commands Olivier Guiter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5B8B1B.7000200@linux.intel.com \
    --to=olivier.guiter@linux.intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.