From: Phil Karn <karn@ka9q.net>
To: richard -rw- weinberger <richard.weinberger@gmail.com>
Cc: kaber@trash.net, netdev@vger.kernel.org
Subject: Re: Off-by-one error in net/8021q/vlan.c
Date: Wed, 16 Feb 2011 08:28:41 -0800 [thread overview]
Message-ID: <4D5BFB39.8070805@ka9q.net> (raw)
In-Reply-To: <AANLkTikNrwd31RBj1gc6kSaT=qodS=A=YntM=72PMbDf@mail.gmail.com>
On 2/16/11 8:10 AM, richard -rw- weinberger wrote:
> On Wed, Feb 16, 2011 at 4:58 PM, Phil Karn <karn@ka9q.net> wrote:
>> On 2/16/11 4:51 AM, richard -rw- weinberger wrote:
>>> On Wed, Feb 16, 2011 at 11:58 AM, Phil Karn <karn@ka9q.net> wrote:
>>>> The range check on vlan_id in register_vlan_device is off by one, and it
>>>> prevents the creation of a vlan interface for vlan ID 4095. (OSX allows
>>>> this, I checked.)
>>>
>>> Then OSX should fix their code. 4095 is reserved.
>>>
>>
>> If it's reserved, then it's up to the user to reserve it.
>
> No.
>
> See:
> http://standards.ieee.org/getieee802/download/802.1Q-2005.pdf
>
Well, then I guess we all know better than the user. That's the Windows
Way...no, wait, I thought this is Linux.
The fact is that I did encounter a misconfigured switch using vlan 4095,
and because of this off-by-one error I was unable to talk to it and fix it.
I was hoping I wouldn't have to patch every new kernel I install.
next prev parent reply other threads:[~2011-02-16 16:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 10:58 Off-by-one error in net/8021q/vlan.c Phil Karn
2011-02-16 12:51 ` richard -rw- weinberger
2011-02-16 13:22 ` Patrick McHardy
2011-02-16 15:58 ` Phil Karn
2011-02-16 16:10 ` richard -rw- weinberger
2011-02-16 16:28 ` Phil Karn [this message]
2011-02-16 16:35 ` richard -rw- weinberger
2011-02-16 16:39 ` Eric Dumazet
2011-02-16 18:41 ` Michał Mirosław
2011-02-21 19:26 ` Brent Cook
2011-02-21 21:47 ` Phil Karn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5BFB39.8070805@ka9q.net \
--to=karn@ka9q.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.