From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fengzhe Zhang <fengzhe.zhang@intel.com>
Subject: Re: [PATCH] iomem: Prevent Dom0 pci bus from allocating
	RAM as I/O space
Date: Thu, 17 Feb 2011 13:32:15 +0800
Message-ID: <4D5CB2DF.80604@intel.com>
References: <1A42CE6F5F474C41B63392A5F80372B2335E978C@shsmsx501.ccr.corp.intel.com>
	<20110216150638.GC12215@dumpdata.com>
	<20110216152021.GA5894@dumpdata.com>
	<20110216154759.GA3921@dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20110216154759.GA3921@dumpdata.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel <xen-devel@lists.xensource.com>, "Dong,
	Eddie" <eddie.dong@intel.com>, "Li, Xin" <xin.li@intel.com>, yunhong.jiang@intel.com
List-Id: xen-devel@lists.xenproject.org

On 2011/2/16 23:47, Konrad Rzeszutek Wilk wrote:
> On Wed, Feb 16, 2011 at 10:20:21AM -0500, Konrad Rzeszutek Wilk wrote:
>> On Wed, Feb 16, 2011 at 10:06:38AM -0500, Konrad Rzeszutek Wilk wrote:
>>> On Wed, Feb 16, 2011 at 10:26:20PM +0800, Zhang, Fengzhe wrote:
>>>> iomem: Prevent Dom0 pci bus from allocating RAM as I/O space
>>>
>>> Is there a bug # associated with this? Is this associated with the intel-agp
>>> driver trying to ioremap the scratch page and bombing out?
>
> Also did you try to revert 0b56d9994ebe34df77fa156d2068ad93b7877b44 and see
> how that works? Here is the revert attached
>

I tried this patch and it can indeed avoid system crash.

However, I still doubt if the igb device is working correctly. The 
sequence that igb driver do ioremap is like this:

1. igb calls function pci_ubs_alloc_resource to get some non-RAM pages.
2. igb sets the phys_addr of the pages in some BAR.
3. igb ioremaps these pages.

After patching, it looks like ioremap gets some mfn allocated by Xen. 
But what set in BAR is still phys_addr. If igb device tries to access 
the pages directly, would Xen be able to intercept and translate it? And 
also, how the contiguity of mfns be guaranteed?

-Fengzhe