From: David Daney <ddaney@caviumnetworks.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Octeon: Kconfig: fix helper dependency
Date: Thu, 17 Feb 2011 10:01:02 -0800 [thread overview]
Message-ID: <4D5D625E.2000503@caviumnetworks.com> (raw)
In-Reply-To: <1297952906-1099-1-git-send-email-antonynpavlov@gmail.com>
On 02/17/2011 06:28 AM, Antony Pavlov wrote:
> The option CAVIUM_OCTEON_HELPER does not depend
> on CPU_CAVIUM_OCTEON option.
> So my .config file for MIPS Malta board contains
>
> CONFIG_MIPS_MALTA=y
> ...
> # CONFIG_CAVIUM_OCTEON_SIMULATOR is not set
> # CONFIG_CAVIUM_OCTEON_REFERENCE_BOARD is not set
> ...
> CONFIG_CAVIUM_OCTEON_HELPER=y
>
> Signed-off-by: Antony Pavlov<antonynpavlov@gmail.com>
NAK.
I have a patch that takes a different approach.
David Daney
> ---
> arch/mips/cavium-octeon/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/Kconfig b/arch/mips/cavium-octeon/Kconfig
> index caae228..a6a2f3c 100644
> --- a/arch/mips/cavium-octeon/Kconfig
> +++ b/arch/mips/cavium-octeon/Kconfig
> @@ -97,7 +97,7 @@ config ARCH_SPARSEMEM_ENABLE
>
> config CAVIUM_OCTEON_HELPER
> def_bool y
> - depends on OCTEON_ETHERNET || PCI
> + depends on CPU_CAVIUM_OCTEON&& (OCTEON_ETHERNET || PCI)
>
> config IOMMU_HELPER
> bool
prev parent reply other threads:[~2011-02-17 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 14:28 [PATCH] MIPS: Octeon: Kconfig: fix helper dependency Antony Pavlov
2011-02-17 18:01 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5D625E.2000503@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=antonynpavlov@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.