All of lore.kernel.org
 help / color / mirror / Atom feed
From: poma <pomidorabelisima@gmail.com>
To: linux-media@vger.kernel.org, Antti Palosaari <crope@iki.fi>,
	andrew.williams@joratech.com, lindsay.mathieson@gmail.com,
	skandalfo@gmail.com, news004@upsilon.org.uk
Subject: Re: Afatech AF9015 & dual tuner - dual_mode B.R.O.K.E.N.
Date: Thu, 17 Feb 2011 23:11:28 +0100	[thread overview]
Message-ID: <4D5D9D10.2060709@gmail.com> (raw)
In-Reply-To: <4D5CE929.4050102@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2229 bytes --]

poma wrote:
> poma wrote:
>> To num_adapters = 2, or num_adapters = 1: that is the question!
> 
> In dual tuner mode, after a while device become unrensponsive,
> eventually after S5 aka 'Soft Off' system doesn't even boot!
> Didn't even mention all sorts of 'mumbo-jumbo' with S3 aka 'Suspend to 
> RAM'.
> Antti, please consider adding 'dual_mode' parameter back.
> 
> "dvb_usb_af9015 dual_mode=0"
> 
> Devices to consider:
> 
> Not Only TV/LifeView DUAL DVB-T USB LV52T
> (equivalent to TerraTec Cinergy T Stick Dual RC)
> Afatech AF9013/AF9015 & 2x MaxLinear MxL5007T
> http://www.notonlytv.net/p_lv52t.html
> 
> KWorld USB Dual DVB-T TV Stick (DVB-T 399U)
> Afatech AF9013/AF9015 & 2x MaxLinear MxL5003S
> http://www.kworld-global.com/main/prod_in.aspx?mnuid=1248&modid=6&prodid=73
> 
> DigitalNow TinyTwin DVB-T Receiver
> Afatech AF9013/AF9015 & 2x MaxLinear MxL5005S
> http://www.digitalnow.com.au/product_pages/TinyTwin.html
> 
> http://www.spinics.net/lists/linux-dvb/msg31616.html
> http://www.spinics.net/lists/linux-dvb/msg31621.html

This patch restore dvb_usb_af9015 'dual mode' parameter - "disable dual 
mode by default because it is buggy".
Enabled mode:
options dvb_usb_af9015 dual_mode=1
in modprobe referent file.

..
--- a/linux/drivers/media/dvb/dvb-usb/af9015.c	2011-01-10 
16:24:45.000000000 +0100
+++ b/linux/drivers/media/dvb/dvb-usb/af9015.c	2011-02-17 
21:58:42.099040739 +0100
@@ -40,6 +40,9 @@
  static int dvb_usb_af9015_remote;
  module_param_named(remote, dvb_usb_af9015_remote, int, 0644);
  MODULE_PARM_DESC(remote, "select remote");
+static int dvb_usb_af9015_dual_mode;
+module_param_named(dual_mode, dvb_usb_af9015_dual_mode, int, 0644);
+MODULE_PARM_DESC(dual_mode, "enable dual mode");
  DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);

  static DEFINE_MUTEX(af9015_usb_mutex);
@@ -841,6 +844,9 @@
  		goto error;
  	af9015_config.dual_mode = val;
  	deb_info("%s: TS mode:%d\n", __func__, af9015_config.dual_mode);
+	/* disable dual mode by default because it is buggy */
+	if (!dvb_usb_af9015_dual_mode)
+		af9015_config.dual_mode = 0;

  	/* Set adapter0 buffer size according to USB port speed, adapter1 buffer
  	   size can be static because it is enabled only USB2.0 */
..

rgds,
poma


[-- Attachment #2: af9015.c_param-dual_mode.patch --]
[-- Type: text/x-patch, Size: 964 bytes --]

--- a/linux/drivers/media/dvb/dvb-usb/af9015.c	2011-01-10 16:24:45.000000000 +0100
+++ b/linux/drivers/media/dvb/dvb-usb/af9015.c	2011-02-17 21:58:42.099040739 +0100
@@ -40,6 +40,9 @@
 static int dvb_usb_af9015_remote;
 module_param_named(remote, dvb_usb_af9015_remote, int, 0644);
 MODULE_PARM_DESC(remote, "select remote");
+static int dvb_usb_af9015_dual_mode;
+module_param_named(dual_mode, dvb_usb_af9015_dual_mode, int, 0644);
+MODULE_PARM_DESC(dual_mode, "enable dual mode");
 DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
 
 static DEFINE_MUTEX(af9015_usb_mutex);
@@ -841,6 +844,9 @@
 		goto error;
 	af9015_config.dual_mode = val;
 	deb_info("%s: TS mode:%d\n", __func__, af9015_config.dual_mode);
+	/* disable dual mode by default because it is buggy */
+	if (!dvb_usb_af9015_dual_mode)
+		af9015_config.dual_mode = 0;
 
 	/* Set adapter0 buffer size according to USB port speed, adapter1 buffer
 	   size can be static because it is enabled only USB2.0 */

  reply	other threads:[~2011-02-17 22:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-16  5:25 Afatech AF9015 & dual tuner - dual_mode B.R.O.K.E.N poma
2011-02-17  9:23 ` poma
2011-02-17 22:11   ` poma [this message]
2011-04-29 12:03     ` Mauro Carvalho Chehab
2011-04-29 12:10       ` Antti Palosaari
2011-04-29 23:06         ` poma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5D9D10.2060709@gmail.com \
    --to=pomidorabelisima@gmail.com \
    --cc=andrew.williams@joratech.com \
    --cc=crope@iki.fi \
    --cc=lindsay.mathieson@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=news004@upsilon.org.uk \
    --cc=skandalfo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.