From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Jan Kiszka <jan.kiszka@web.de>
Subject: [Qemu-devel] Re: [PATCH] fix halt emulation with icount and CONFIG_IOTHREAD (v2)
Date: Fri, 18 Feb 2011 18:13:27 +0100 [thread overview]
Message-ID: <4D5EA8B7.3080206@redhat.com> (raw)
In-Reply-To: <4D5CDBFF.3030808@redhat.com>
On 02/17/2011 09:27 AM, Paolo Bonzini wrote:
> It is "-icount N" which is broken and unfortunately your patch does not
> fix it.
The problem is that for "use_icount == 1" qemu_icount_delta always
returns 0, and this makes no sense in the iothread case. As soon as the
delta becomes greater than 10 ms (the maximum adjustment in
qemu_calculate_timeout) you just keep polling but hardly execute any code.
I'll try to post something in the weekend.
Paolo
next prev parent reply other threads:[~2011-02-18 17:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 17:54 [Qemu-devel] [PATCH] fix halt emulation with icount and CONFIG_IOTHREAD Marcelo Tosatti
2011-02-15 18:58 ` [Qemu-devel] " Jan Kiszka
2011-02-15 20:04 ` Marcelo Tosatti
2011-02-15 20:33 ` Jan Kiszka
2011-02-15 20:55 ` Marcelo Tosatti
2011-02-15 20:56 ` [Qemu-devel] [PATCH] fix halt emulation with icount and CONFIG_IOTHREAD (v2) Marcelo Tosatti
2011-02-16 8:27 ` [Qemu-devel] " Jan Kiszka
2011-02-16 9:32 ` Paolo Bonzini
2011-02-16 9:46 ` Jan Kiszka
2011-02-16 9:57 ` Paolo Bonzini
2011-02-16 10:04 ` Jan Kiszka
2011-02-16 10:27 ` Paolo Bonzini
2011-02-16 10:34 ` Jan Kiszka
2011-02-16 11:05 ` Paolo Bonzini
2011-02-17 3:15 ` Marcelo Tosatti
2011-02-17 8:27 ` Paolo Bonzini
2011-02-18 17:13 ` Paolo Bonzini [this message]
2011-02-17 8:29 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5EA8B7.3080206@redhat.com \
--to=pbonzini@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=jan.kiszka@web.de \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.