From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1PqmIS-00088j-Op for mharc-grub-devel@gnu.org; Sat, 19 Feb 2011 07:52:24 -0500 Received: from [140.186.70.92] (port=44212 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PqmIQ-00088b-28 for grub-devel@gnu.org; Sat, 19 Feb 2011 07:52:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PqmIO-00066y-FL for grub-devel@gnu.org; Sat, 19 Feb 2011 07:52:21 -0500 Received: from mail-ew0-f41.google.com ([209.85.215.41]:38410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PqmIO-00066n-A1 for grub-devel@gnu.org; Sat, 19 Feb 2011 07:52:20 -0500 Received: by ewy10 with SMTP id 10so280699ewy.0 for ; Sat, 19 Feb 2011 04:52:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:x-enigmail-version:content-type; bh=Lsv5XRgQErRMyVz3UvBUZdjESrmZoHY7kMiGuxKpfdw=; b=m/cA42Xt419szkVMKSHGUyU4km9B0ZRn6UEJ2Un9gBxX78Ynn3xkgmcer9y8djnbyb VupGMzGow3jCMsMbzYk4no64P9VU0yE9NlL1ltCtiNLO7Hyp+ejVt80kxoxczNIE/QpM PpDtjHxwgQB3xnOnRZ0uXZtl8NoeguUbOyaF0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type; b=SsRl74MAdbQ1kAgHKV8q3qze7K35HtsGPlowyRYMAJHkOcar+iBanegLDyBjYjywEK +IrNBhhGQZZUnBHiSqcIP2wJk5erCbwH/1uyVJrQb97cK+deKRDzr06Ad0BZ7SLAsVKe GYzto2WiQvfwaMPRzXyTffzwi4Tx3VwezNvHY= Received: by 10.14.29.77 with SMTP id h53mr2116633eea.18.1298119938748; Sat, 19 Feb 2011 04:52:18 -0800 (PST) Received: from debian.x201.phnet (67-84.62-81.cust.bluewin.ch [81.62.84.67]) by mx.google.com with ESMTPS id b52sm2877484eei.13.2011.02.19.04.52.14 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 19 Feb 2011 04:52:17 -0800 (PST) Message-ID: <4D5FBCF2.1080308@gmail.com> Date: Sat, 19 Feb 2011 13:52:02 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20101226 Icedove/3.0.11 MIME-Version: 1.0 To: Fam Cook References: <4C87AB1A.9060208@gmail.com> In-Reply-To: X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig1CED99589B2C801E0344E052" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.215.41 Cc: The development of GNU GRUB , Arun Thomas , Erik van der Kouwe Subject: Re: [PATCH] MINIX file system version 3 support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Feb 2011 12:52:23 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1CED99589B2C801E0344E052 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/19/2011 09:43 AM, Fam Cook wrote: > As I've done the assignment of contributor copyright with FSF, I'd > like to send this patch here once more, as introduced in quoting, it's > for MINIX3 FS support. Already updated based on the latest trunk code, > please check and notify me if more adjust needed. > > =20 I know. I've seen it but I've been travelling so unfortunately haven't handled it yet. > 2010/9/8 Vladimir '=CF=86-coder/phcoder' Serbinenko = : > =20 >> On 07/28/2010 05:25 AM, Fam Zheng wrote: >> =20 >>> Hi, >>> >>> To support MINIX file system version 3, this patch adds a new module >>> named 'minix3'. It reuses most of the code in minix.mod, and handles >>> the latest MINIX file system version 3. >>> >>> The requested assignment information has also been sent to >>> assign@gnu.org . >>> >>> =20 >> Please, ensure that patches have correct mime type. It's annoying to >> have to save them separately just to view. >> struct grub_minix_inode inode; >> struct grub_minix2_inode inode2; >> +#ifdef GRUB_MOD_MINIX3 >> inode and inode2 shouldn't be present in minix3 structure. >> >> +static unsigned int blocksize; >> + >> All FS info must be in _data structure. Otherwise 2 simultaneously >> mounted filesystems will conflict. >> +#ifdef GRUB_MOD_MINIX3 >> + first_dbl_indir=3Dindir_capacity+7; >> + if (blk < first_dbl_indir) >> + { >> + blk -=3D 7; >> + indir =3D grub_get_indir (GRUB_MINIX_INODE_INDIR_ZONE (data), b= lk); >> + return indir; >> + } >> +#else >> Where does 7 come from? It must be macroified. >> >> + if(ino=3D=3D0) return GRUB_ERR_BAD_ARGUMENT; >> must be 2 lines and return should be return grub_error (GRUB_ERR_BAD_F= S, >> "incorrect inode"); >> +#define GRUB_MOD_MINIX3 >> +#include "minix.c" >> It should be MODE_MINIX3 >> I'm now splitting minix.mod into minix.mod nd minix2.mod, once I'm >> finished please adjust your patch >> -- >> =20 >>> Best Regards! >>> Fam Zheng >>> >>> >>> _______________________________________________ >>> Grub-devel mailing list >>> Grub-devel@gnu.org >>> http://lists.gnu.org/mailman/listinfo/grub-devel >>> >>> =20 >> >> -- >> Regards >> Vladimir '=CF=86-coder/phcoder' Serbinenko >> >> >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> http://lists.gnu.org/mailman/listinfo/grub-devel >> >> >> =20 > > > -- > Best regards! > Fam Zheng > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig1CED99589B2C801E0344E052 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk1fvPwACgkQNak7dOguQgnoUQD9HatMEb/fB4ZnbjqRLfaWwple YytTW9Gf329skRHPEhkA/2x5h+lZzpIciEKtFzSVekVjsgjdog0CY7aJDyihDJ7a =H2jd -----END PGP SIGNATURE----- --------------enig1CED99589B2C801E0344E052--