From: Hannes Reinecke <hare@suse.de>
To: adam radford <aradford@gmail.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>, Bo.Yang@lsi.com
Subject: Re: [PATCH 5/15] megaraid_sas: Fix probe_one to clear MSI-X flags in kdump
Date: Mon, 21 Feb 2011 09:04:19 +0100 [thread overview]
Message-ID: <4D621C83.1090707@suse.de> (raw)
In-Reply-To: <AANLkTinMo1nnUhiYi=Rfnnts9zqqSf_UuaYUt_gyJW3B@mail.gmail.com>
On 02/20/2011 03:22 AM, adam radford wrote:
> James/Linux-scsi,
>
> The following patch for megaraid_sas fixes megasas_probe_one() to
> clear MSI-X flags in kdump when the 'reset_devices' kernel parameter
> is passed in.
>
This is actually the one bit where I'm quite puzzled by.
Problem here is the pci_enable_msix() actually fails when MSI-X is
already enabled. Which is odd, given that MSI-X _is_ enabled
already, so taken at face value pci_enable_msix() shouldn't fail here.
I know that there are several stages to the MSI-X initialisation, so
this is the safe route here. But I also have seen _LOTS_ of failures
with kdump and raid HBAs, most of which point to the same problem here.
Can't we put in a 'force' parameter to pci_enable_msix() to avoid
having to code this one in each and every driver?
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-02-21 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 2:22 [PATCH 5/15] megaraid_sas: Fix probe_one to clear MSI-X flags in kdump adam radford
2011-02-21 8:04 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D621C83.1090707@suse.de \
--to=hare@suse.de \
--cc=Bo.Yang@lsi.com \
--cc=aradford@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.