From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60886 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PrSYd-0001BA-AY
	for qemu-devel@nongnu.org; Mon, 21 Feb 2011 05:00:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <christophe.lyon@st.com>) id 1PrSYX-0007Hn-PH
	for qemu-devel@nongnu.org; Mon, 21 Feb 2011 04:59:50 -0500
Received: from eu1sys200aog117.obsmtp.com ([207.126.144.143]:50861)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christophe.lyon@st.com>) id 1PrSYX-0007G2-Hn
	for qemu-devel@nongnu.org; Mon, 21 Feb 2011 04:59:49 -0500
Message-ID: <4D62377A.1080805@st.com>
Date: Mon, 21 Feb 2011 10:59:22 +0100
From: Christophe Lyon <christophe.lyon@st.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/4] softfloat: add float32_set_sign(),
	float32_infinity, float64_half, float64_256 and float64_512.
References: <1298040557-6342-1-git-send-email-christophe.lyon@st.com>
	<1298040557-6342-3-git-send-email-christophe.lyon@st.com>
	<20110220215241.GN4580@hall.aurel32.net>
	<AANLkTi=agwV+zDfsdjDo=3b12n9QpDO_XURYQnum=5K=@mail.gmail.com>
	<20110220222033.GP4580@hall.aurel32.net>
In-Reply-To: <20110220222033.GP4580@hall.aurel32.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "g@hall.aurel32.net" <g@hall.aurel32.net>

On 20.02.2011 23:20, Aurelien Jarno wrote:
> On Sun, Feb 20, 2011 at 10:09:46PM +0000, Peter Maydell wrote:
>> On 20 February 2011 21:52, Aurelien Jarno <aurelien@aurel32.net> wrote:
>>> While it's probably a good idea to define the commonly used values in
>>> softfloat.h, I don't think we should have all the values used by the
>>> different targets here. Infinity, one, half, two probably have their
>>> place here, I don't think it's the case of 256 and 512. It should be
>>> better to defined them at the target level.
>>
>> Are you happy with targets just doing make_float*() on a
>> bit pattern? I guess that's the most straightforward thing,
> 
> Yes, I think it is the way to go.
> 
OK I will change that.


>>> Also for consistency, I
>>> think it's better to define these value for all float size, or at least
>>> for all the common ones (32, 64, maybe 16).
>>
>> I wouldn't bother with 16, only ARM uses that and only for
>> conversions to other formats.
>>
> 
> That's true, so let's do it float 32 and 64.
> 
I will add these too.

Christophe.