From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 07/21] add assertions on the owner of a QemuMutex
Date: Mon, 21 Feb 2011 11:15:39 +0100 [thread overview]
Message-ID: <4D623B4B.8020306@redhat.com> (raw)
In-Reply-To: <4D623556.7050204@siemens.com>
On 02/21/2011 10:50 AM, Jan Kiszka wrote:
>> > + /* An EDEADLOCK would arrive after we reset the owner. So this
>> > + assert is for ease of debugging (it lets you see what is the
>> > + actual owner. */
>
> Don't get this. Why do you want to avoid the proper error detection of
> pthread?
Because by the time you get to error_exit mutex->owner has been NULL-ed
out already. So it doesn't help to put a breakpoint on error_exit, you
cannot find out which thread was the owner.
> But the assertions in the mutex layer
> are redundant for PTHREAD_MUTEX_ERRORCHECK - unless I'm missing
> something now.
Yes, but tracking the mutex's owner gives a bit more specific
information when an error happens even for mutexes. I removed them from
lock/trylock, but for unlock it's already too late when the error happens.
Paolo
next prev parent reply other threads:[~2011-02-21 10:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 8:43 [Qemu-devel] [PATCH uq/master 00/21] Win32 iothread support Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 01/21] unlock iothread during WaitForMultipleObjects Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 02/21] implement win32 dynticks timer Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 03/21] use win32 timer queues Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 04/21] replace qemu_thread_equal API with qemu_thread_is_current Paolo Bonzini
2011-02-21 9:41 ` [Qemu-devel] " Jan Kiszka
2011-02-21 11:14 ` Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 05/21] add win32 qemu-thread implementation Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 06/21] include qemu-thread.h early Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 07/21] add assertions on the owner of a QemuMutex Paolo Bonzini
2011-02-21 9:50 ` [Qemu-devel] " Jan Kiszka
2011-02-21 10:15 ` Paolo Bonzini [this message]
2011-02-21 10:22 ` Jan Kiszka
2011-02-21 10:23 ` Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 08/21] remove CONFIG_THREAD Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 09/21] inline cpu_halted into sole caller Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 10/21] always qemu_cpu_kick after unhalting a cpu Paolo Bonzini
2011-02-21 9:51 ` [Qemu-devel] " Jan Kiszka
2011-02-21 8:43 ` [Qemu-devel] [PATCH 11/21] exit round-robin vcpu loop if cpu->stopped is true Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 12/21] always signal pause_cond after stopping a VCPU Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 13/21] do not use timedwait on qemu_halt_cond Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 14/21] do not use timedwait on qemu_system_cond Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 15/21] do not use timedwait on qemu_pause_cond Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 16/21] do not use timedwait on qemu_cpu_cond Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 17/21] iothread stops the vcpu thread via IPI Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 18/21] move blocking of signals to qemu_signalfd_init Paolo Bonzini
2011-02-21 10:12 ` [Qemu-devel] " Jan Kiszka
2011-02-21 10:20 ` Paolo Bonzini
2011-02-21 10:26 ` Jan Kiszka
2011-02-21 8:43 ` [Qemu-devel] [PATCH 19/21] provide dummy signal init functions for win32 Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 20/21] protect qemu_cpu_kick_self for Win32 Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 21/21] add Win32 IPI service Paolo Bonzini
2011-02-21 12:00 ` [Qemu-devel] " Jan Kiszka
2011-02-21 12:15 ` Paolo Bonzini
2011-02-21 12:25 ` Jan Kiszka
2011-02-22 20:35 ` [Qemu-devel] [PATCH uq/master 00/21] Win32 iothread support Anthony Liguori
2011-02-23 7:29 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D623B4B.8020306@redhat.com \
--to=pbonzini@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.