From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: ext Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: omap: rx51: Add FM transmitter support
Date: Tue, 22 Feb 2011 08:59:11 +0200 [thread overview]
Message-ID: <4D635EBF.3040409@nokia.com> (raw)
In-Reply-To: <1298293042-13801-1-git-send-email-jhnikula@gmail.com>
On 02/21/11 14:57, ext Jarkko Nikula wrote:
> Si4713 FM transmitter on Nokia RX-51/N900 is connected to same Line out
> signals of TLV320AIC34 than TPA6130 headphone amplifier.
>
> This patch adds route to transmitter and "FM Transmitter" control to keep
> route active when needed.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
...
> {"DMic Rate 64", NULL, "Mic Bias 2V"},
> {"Mic Bias 2V", NULL, "DMic"},
> @@ -292,6 +295,7 @@ static const struct snd_kcontrol_new aic34_rx51_controls[] = {
> rx51_get_input, rx51_set_input),
> SOC_ENUM_EXT("Jack Function", rx51_enum[2],
> rx51_get_jack, rx51_set_jack),
Have you thought of converting the 'Jack Function' to DAPM_PIN_SWITCH as
well?
> + SOC_DAPM_PIN_SWITCH("FM Transmitter"),
> };
>
> static const struct snd_kcontrol_new aic34_rx51_controlsb[] = {
Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
next prev parent reply other threads:[~2011-02-22 6:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 12:57 [PATCH] ASoC: omap: rx51: Add FM transmitter support Jarkko Nikula
2011-02-21 18:44 ` Mark Brown
2011-02-22 6:59 ` Peter Ujfalusi [this message]
2011-02-22 7:18 ` Jarkko Nikula
2011-02-22 9:41 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D635EBF.3040409@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jhnikula@gmail.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.