All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benny Halevy <bhalevy@panasas.com>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH] NFSD: fix decode_cb_sequence4resok
Date: Tue, 22 Feb 2011 16:15:22 -0800	[thread overview]
Message-ID: <4D64519A.8050604@panasas.com> (raw)
In-Reply-To: <20110223001100.GC5543@pad.home.fieldses.org>

On 2011-02-22 16:11, J. Bruce Fields wrote:
> On Tue, Feb 22, 2011 at 02:43:22PM -0800, Benny Halevy wrote:
>> Fix bug introduced in patch
>> 85a56480 NFSD: Update XDR decoders in NFSv4 callback client
>>
>> Although decode_cb_sequence4resok ignores highest slotid and target highest slotid
>> it must account for their space in their xdr stream when calling xdr_inline_decode
> 
> Thanks, applying for 2.6.38.  (How come you caught this, and I didn't?
> I guess it's just that the object code depends more on the callback
> returns?)

That's a great question.
I caught it by testing cb_layoutrecall, both with the objects layout
and with the files layout with the patch I sent for PNFSD_LEXP to recall the
layout on truncate.
cb_recall decoding should be broken too at the server.
It's possible nothing really depends on its status.

Benny

> 
> --b.
> 
>>

  reply	other threads:[~2011-02-23  0:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22 22:43 [PATCH] NFSD: fix decode_cb_sequence4resok Benny Halevy
2011-02-23  0:11 ` J. Bruce Fields
2011-02-23  0:15   ` Benny Halevy [this message]
2011-02-23  0:24     ` J. Bruce Fields
2011-02-23 16:48 ` Chuck Lever
2011-02-23 17:08   ` Benny Halevy
2011-02-23 17:29     ` J. Bruce Fields
2011-02-23 18:07       ` Benny Halevy
2011-02-23 18:43         ` Benny Halevy
2011-02-25  0:36           ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D64519A.8050604@panasas.com \
    --to=bhalevy@panasas.com \
    --cc=bfields@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.