From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: Q: status of kvm/ subdir in qemu-kvm tarball? Date: Wed, 23 Feb 2011 13:58:33 +0100 Message-ID: <4D650479.30609@siemens.com> References: <4D64E9C6.8000505@msgid.tls.msk.ru> <4D64F008.7050308@siemens.com> <4D64F2C0.4000609@msgid.tls.msk.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: KVM list To: Michael Tokarev Return-path: Received: from goliath.siemens.de ([192.35.17.28]:26247 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754355Ab1BWM6j (ORCPT ); Wed, 23 Feb 2011 07:58:39 -0500 In-Reply-To: <4D64F2C0.4000609@msgid.tls.msk.ru> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-02-23 12:42, Michael Tokarev wrote: > 23.02.2011 14:31, Jan Kiszka wrote: >> On 2011-02-23 12:04, Michael Tokarev wrote: >>> What's the current status of files in kvm/ subdirectory >>> in the qemu-kvm distribution (0.14 or git) ? > [] >> I think there are a few bits still in use: >> >> - kvm/kvm_stat > > this is a tiny useful tool, yes, and we package > it. > >> - kvm/include (latest kernel headers) *) > > This directory is always used (in configure) > unless -kerneldir is specified - who uses that > nowadays? I dunno. It may not be relevant to distros, provided they manage to keep their /usr/include/linux stuff in sync with the kernel they ship. But if you build qemu-kvm for a kernel (or kvm-kmod) that is more recent than your user space headers, this matters. > >> Otherwise, removing this cruft would be good. >> >> Jan >> >> *) This should really be discussed upstream again: Carry private copy of >> kvm headers or rely on distro / kvm-kmod to provide required defines, >> types etc.? I'm more and more in favor of option 1. > > Yes indeed, having current defines of all the features > we actually support is a good idea. Would you like to propose this upstream in form of a patch series (that demonstrates its usefulness by dropping tones of #ifdefs)? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux