From: "Christopher J. PeBenito" <cpebenito@tresys.com>
To: Eric Paris <eparis@redhat.com>
Cc: selinux@tycho.nsa.gov, sds@tycho.nsa.gov, jmorris@namei.org
Subject: Re: [PATCH] selinux: drop unused packet flow permissions
Date: Wed, 23 Feb 2011 08:40:55 -0500 [thread overview]
Message-ID: <4D650E67.2040800@tresys.com> (raw)
In-Reply-To: <20110223025438.17536.15362.stgit@paris.rdu.redhat.com>
On 02/22/11 21:54, Eric Paris wrote:
> These permissions are not used and can be dropped in the kernel
> definitions.
>
> Suggested-by: Stephen Smalley <sds@tycho.nsa.gov>
> Signed-off-by: Eric Paris <eparis@redhat.com>
> ---
>
> security/selinux/include/classmap.h | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/security/selinux/include/classmap.h b/security/selinux/include/classmap.h
> index e9a8eb7..fffd855 100644
> --- a/security/selinux/include/classmap.h
> +++ b/security/selinux/include/classmap.h
> @@ -132,8 +132,7 @@ struct security_class_mapping secclass_map[] = {
> { "appletalk_socket",
> { COMMON_SOCK_PERMS, NULL } },
> { "packet",
> - { "send", "recv", "relabelto", "flow_in", "flow_out",
> - "forward_in", "forward_out", NULL } },
> + { "send", "recv", "relabelto", "forward_in", "forward_out", NULL } },
> { "key",
> { "view", "read", "write", "search", "link", "setattr", "create",
> NULL } },
I'm concerned about this. Won't this break refpolicy? I can't keep two
sets of object class definitions around for systems that still have the
flow_in and flow_out perms.
--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2011-02-23 13:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 2:54 [PATCH] selinux: drop unused packet flow permissions Eric Paris
2011-02-23 13:40 ` Christopher J. PeBenito [this message]
2011-02-23 13:57 ` Stephen Smalley
-- strict thread matches above, loose matches on Subject: below --
2011-02-23 2:54 Eric Paris
2011-02-23 15:22 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D650E67.2040800@tresys.com \
--to=cpebenito@tresys.com \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.