All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, Neil Horman <nhorman@redhat.com>,
	Herbert Xu <herbert@gondor.hengli.com.au>,
	"David S. Miller" <davem@davemloft.net>,
	Neil Horman <nhorman@tuxdriver.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	netdev@vger.kernel.org
Subject: Re: [V4 PATCH 3/3] bond: service netpoll arp queue on master device
Date: Wed, 23 Feb 2011 23:24:45 +0800	[thread overview]
Message-ID: <4D6526BD.6030306@redhat.com> (raw)
In-Reply-To: <1298022215-21059-3-git-send-email-amwang@redhat.com>

Neil, ping. :)

于 2011年02月18日 17:43, Amerigo Wang 写道:
> Neil pointed out that we can't send ARP reply on behalf of slaves,
> we need to move the arp queue to their bond device.
>
> Signed-off-by: WANG Cong<amwang@redhat.com>
> Cc: Neil Horman<nhorman@redhat.com>
>
> ---
>   net/core/netpoll.c |    9 +++++++++
>   1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> index f68e694..013e04a 100644
> --- a/net/core/netpoll.c
> +++ b/net/core/netpoll.c
> @@ -193,6 +193,15 @@ void netpoll_poll_dev(struct net_device *dev)
>
>   	poll_napi(dev);
>
> +	if (dev->priv_flags&  IFF_SLAVE) {
> +		if (dev->npinfo) {
> +			struct net_device *bond_dev = dev->master;
> +			struct sk_buff *skb;
> +			while ((skb = skb_dequeue(&dev->npinfo->arp_tx)))
> +				skb_queue_tail(&bond_dev->npinfo->arp_tx, skb);
> +		}
> +	}
> +
>   	service_arp_queue(dev->npinfo);
>
>   	zap_completion_queue();


-- 
我认识的人越多,我就越喜欢狗。

  reply	other threads:[~2011-02-23 15:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-18  9:43 [V4 PATCH 1/3] bonding: sync netpoll code with bridge Amerigo Wang
2011-02-18  9:43 ` [V4 PATCH 2/3] netpoll: remove IFF_IN_NETPOLL flag Amerigo Wang
2011-02-28  0:12   ` David Miller
2011-02-18  9:43 ` [V4 PATCH 3/3] bond: service netpoll arp queue on master device Amerigo Wang
2011-02-23 15:24   ` Cong Wang [this message]
2011-02-23 15:30     ` Neil Horman
2011-02-23 15:34       ` Cong Wang
2011-02-28  0:12   ` David Miller
2011-02-28  3:32     ` Cong Wang
2011-02-28  4:12       ` David Miller
2011-02-28  0:12 ` [V4 PATCH 1/3] bonding: sync netpoll code with bridge David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6526BD.6030306@redhat.com \
    --to=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=herbert@gondor.hengli.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.