From: David Daney <ddaney@caviumnetworks.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 01/10] MIPS: Octeon: Move some Ethernet support files out of staging.
Date: Wed, 23 Feb 2011 09:36:13 -0800 [thread overview]
Message-ID: <4D65458D.5080908@caviumnetworks.com> (raw)
In-Reply-To: <20110223144805.GC3143@angua.secretlab.ca>
On 02/23/2011 06:48 AM, Grant Likely wrote:
> On Tue, Feb 22, 2011 at 12:57:45PM -0800, David Daney wrote:
>> Signed-off-by: David Daney<ddaney@caviumnetworks.com>
>
> If this is an Ethernet driver, then it belongs in drivers/net and you
> should cc both netdev and Dave Miller.
>
Eventually the files need to go somewhere other than drivers/staging.
They are not all Ethernet related, so sorting out exactly where they all
go is not so simple. This subject has been a thorn in my side for quite
some time.
For the sake of getting the Device Tree patching code working and to
generate Device Tree related feedback, I moved them to be with their kin
in arch/mips/cavium-octeon/executive.
In the context of this patch set, I consider this to be a somewhat minor
detail.
David Daney
> g.
>
>> ---
>> arch/mips/cavium-octeon/executive/Makefile | 5 +
>> .../mips/cavium-octeon/executive}/cvmx-cmd-queue.c | 8 +-
>> .../mips/cavium-octeon/executive}/cvmx-fpa.c | 0
>> .../cavium-octeon/executive}/cvmx-helper-board.c | 18 +--
>> .../cavium-octeon/executive}/cvmx-helper-fpa.c | 0
>> .../cavium-octeon/executive}/cvmx-helper-loop.c | 6 +-
>> .../cavium-octeon/executive}/cvmx-helper-npi.c | 6 +-
>> .../cavium-octeon/executive}/cvmx-helper-rgmii.c | 17 +-
>> .../cavium-octeon/executive}/cvmx-helper-sgmii.c | 12 +-
>> .../cavium-octeon/executive}/cvmx-helper-spi.c | 10 +-
>> .../cavium-octeon/executive}/cvmx-helper-util.c | 16 +-
>> .../cavium-octeon/executive}/cvmx-helper-xaui.c | 10 +-
>> .../mips/cavium-octeon/executive}/cvmx-helper.c | 27 ++--
>> .../executive}/cvmx-interrupt-decodes.c | 10 +-
>> .../cavium-octeon/executive}/cvmx-interrupt-rsl.c | 4 +-
>> .../mips/cavium-octeon/executive}/cvmx-pko.c | 6 +-
>> .../mips/cavium-octeon/executive}/cvmx-spi.c | 12 +-
>> .../mips/include/asm}/octeon/cvmx-address.h | 0
>> .../mips/include/asm}/octeon/cvmx-asxx-defs.h | 0
>> .../mips/include/asm}/octeon/cvmx-cmd-queue.h | 0
>> .../mips/include/asm}/octeon/cvmx-config.h | 0
>> .../mips/include/asm}/octeon/cvmx-dbg-defs.h | 0
>> .../mips/include/asm}/octeon/cvmx-fau.h | 0
>> .../mips/include/asm}/octeon/cvmx-fpa-defs.h | 0
>> .../mips/include/asm}/octeon/cvmx-fpa.h | 0
>> .../mips/include/asm}/octeon/cvmx-gmxx-defs.h | 0
>> .../mips/include/asm}/octeon/cvmx-helper-board.h | 0
>> .../mips/include/asm}/octeon/cvmx-helper-fpa.h | 0
>> .../mips/include/asm}/octeon/cvmx-helper-loop.h | 0
>> .../mips/include/asm}/octeon/cvmx-helper-npi.h | 0
>> .../mips/include/asm}/octeon/cvmx-helper-rgmii.h | 0
>> .../mips/include/asm}/octeon/cvmx-helper-sgmii.h | 0
>> .../mips/include/asm}/octeon/cvmx-helper-spi.h | 0
>> .../mips/include/asm}/octeon/cvmx-helper-util.h | 0
>> .../mips/include/asm}/octeon/cvmx-helper-xaui.h | 0
>> .../mips/include/asm}/octeon/cvmx-helper.h | 0
>> .../mips/include/asm}/octeon/cvmx-ipd.h | 0
>> .../mips/include/asm}/octeon/cvmx-mdio.h | 0
>> .../mips/include/asm}/octeon/cvmx-pcsx-defs.h | 0
>> .../mips/include/asm}/octeon/cvmx-pcsxx-defs.h | 0
>> .../mips/include/asm}/octeon/cvmx-pip-defs.h | 0
>> .../mips/include/asm}/octeon/cvmx-pip.h | 0
>> .../mips/include/asm}/octeon/cvmx-pko-defs.h | 0
>> .../mips/include/asm}/octeon/cvmx-pko.h | 0
>> .../mips/include/asm}/octeon/cvmx-pow.h | 0
>> .../mips/include/asm}/octeon/cvmx-scratch.h | 0
>> .../mips/include/asm}/octeon/cvmx-spi.h | 0
>> .../mips/include/asm}/octeon/cvmx-spxx-defs.h | 0
>> .../mips/include/asm}/octeon/cvmx-srxx-defs.h | 0
>> .../mips/include/asm}/octeon/cvmx-stxx-defs.h | 0
>> .../mips/include/asm}/octeon/cvmx-wqe.h | 0
>> drivers/staging/octeon/Makefile | 5 -
>> drivers/staging/octeon/cvmx-packet.h | 65 -------
>> drivers/staging/octeon/cvmx-smix-defs.h | 178 --------------------
>> drivers/staging/octeon/ethernet-defines.h | 2 +-
>> drivers/staging/octeon/ethernet-mdio.c | 4 +-
>> drivers/staging/octeon/ethernet-mem.c | 2 +-
>> drivers/staging/octeon/ethernet-rgmii.c | 4 +-
>> drivers/staging/octeon/ethernet-rx.c | 14 +-
>> drivers/staging/octeon/ethernet-rx.h | 2 +-
>> drivers/staging/octeon/ethernet-sgmii.c | 4 +-
>> drivers/staging/octeon/ethernet-spi.c | 6 +-
>> drivers/staging/octeon/ethernet-tx.c | 12 +-
>> drivers/staging/octeon/ethernet-xaui.c | 4 +-
>> drivers/staging/octeon/ethernet.c | 14 +-
>> 65 files changed, 116 insertions(+), 367 deletions(-)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-cmd-queue.c (98%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-fpa.c (100%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-helper-board.c (98%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-helper-fpa.c (100%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-helper-loop.c (95%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-helper-npi.c (96%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-helper-rgmii.c (97%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-helper-sgmii.c (98%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-helper-spi.c (97%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-helper-util.c (97%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-helper-xaui.c (98%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-helper.c (98%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-interrupt-decodes.c (98%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-interrupt-rsl.c (97%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-pko.c (99%)
>> rename {drivers/staging/octeon => arch/mips/cavium-octeon/executive}/cvmx-spi.c (99%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-address.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-asxx-defs.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-cmd-queue.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-config.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-dbg-defs.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-fau.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-fpa-defs.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-fpa.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-gmxx-defs.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-helper-board.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-helper-fpa.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-helper-loop.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-helper-npi.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-helper-rgmii.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-helper-sgmii.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-helper-spi.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-helper-util.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-helper-xaui.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-helper.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-ipd.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-mdio.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-pcsx-defs.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-pcsxx-defs.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-pip-defs.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-pip.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-pko-defs.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-pko.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-pow.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-scratch.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-spi.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-spxx-defs.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-srxx-defs.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-stxx-defs.h (100%)
>> rename {drivers/staging => arch/mips/include/asm}/octeon/cvmx-wqe.h (100%)
>> delete mode 100644 drivers/staging/octeon/cvmx-packet.h
>> delete mode 100644 drivers/staging/octeon/cvmx-smix-defs.h
>>
next prev parent reply other threads:[~2011-02-23 17:36 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 20:57 [RFC PATCH 00/10] MIPS: Octeon: Use Device Tree David Daney
2011-02-22 20:57 ` [RFC PATCH 01/10] MIPS: Octeon: Move some Ethernet support files out of staging David Daney
2011-02-23 14:48 ` Grant Likely
2011-02-23 17:36 ` David Daney [this message]
2011-02-22 20:57 ` [RFC PATCH 02/10] MIPS: Octeon: Add device tree source files David Daney
2011-02-22 20:57 ` David Daney
2011-02-23 0:07 ` David Gibson
2011-02-23 14:30 ` Ralf Baechle
2011-02-23 14:30 ` Ralf Baechle
2011-02-23 16:59 ` David Daney
2011-02-23 16:59 ` David Daney
2011-02-24 23:19 ` David Gibson
2011-02-24 23:19 ` David Gibson
2011-02-25 15:22 ` Grant Likely
2011-02-25 15:22 ` Grant Likely
2011-02-25 21:46 ` Benjamin Herrenschmidt
2011-02-25 21:46 ` Benjamin Herrenschmidt
2011-02-23 19:06 ` David Daney
2011-02-23 19:06 ` David Daney
2011-02-23 23:49 ` David Gibson
2011-02-23 23:49 ` David Gibson
2011-02-24 1:57 ` David Daney
2011-02-24 2:14 ` David Gibson
2011-02-24 2:14 ` David Gibson
2011-02-24 2:22 ` David Daney
2011-02-24 2:22 ` David Daney
2011-02-22 20:57 ` [RFC PATCH 03/10] MIPS: Prune some target specific code out of prom.c David Daney
2011-02-22 20:57 ` David Daney
2011-02-22 20:57 ` [RFC PATCH 04/10] MIPS: Octeon: Add a irq_create_of_mapping() implementation David Daney
2011-02-22 20:57 ` David Daney
2011-02-22 20:57 ` [RFC PATCH 05/10] MIPS: Octeon: Rearrance CVMX files in preperation for device tree David Daney
2011-02-22 20:57 ` David Daney
2011-02-22 20:57 ` [RFC PATCH 06/10] MIPS: Octeon: Initialize and fixup " David Daney
2011-02-23 0:16 ` David Gibson
2011-02-23 17:41 ` Grant Likely
2011-02-23 18:40 ` David Daney
2011-02-23 18:40 ` David Daney
2011-02-23 18:51 ` Grant Likely
2011-02-23 19:20 ` David Daney
2011-02-22 20:57 ` [RFC PATCH 07/10] i2c: Convert i2c-octeon.c to use " David Daney
2011-02-23 16:25 ` Grant Likely
2011-02-22 20:57 ` [RFC PATCH 08/10] netdev: mdio-octeon.c: Convert " David Daney
2011-02-22 20:57 ` David Daney
2011-02-22 20:57 ` [RFC PATCH 09/10] netdev: octeon_mgmt: " David Daney
2011-02-23 16:32 ` Grant Likely
2011-02-23 16:32 ` Grant Likely
2011-02-23 20:33 ` David Miller
2011-02-22 20:57 ` [RFC PATCH 10/10] staging: octeon_ethernet: " David Daney
2011-02-22 20:57 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D65458D.5080908@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.