From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zdenek Kabelac <zkabelac@redhat.com>
Date: Wed, 23 Feb 2011 19:40:16 +0100
Subject: [PATCH 1/3] Refactor vg allocation code
In-Reply-To: <20110223164836.GA3626@agk-dp.fab.redhat.com>
References: <cover.1298466569.git.zkabelac@redhat.com>
	<95e375249a799ab7c5cb4d2f8ebf63e446c5364a.1298466569.git.zkabelac@redhat.com>
	<20110223164836.GA3626@agk-dp.fab.redhat.com>
Message-ID: <4D655490.8040102@redhat.com>
List-Id: <lvm-devel.redhat.com>
To: lvm-devel@redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Dne 23.2.2011 17:48, Alasdair G Kergon napsal(a):
> On Wed, Feb 23, 2011 at 02:52:15PM +0100, Zdenek Kabelac wrote:
>> Usure about naming strategy - we use  i.e. alloc_lv,
>> but most the new function have now operation prefix.
>  
> alloc_vg for now...because it's paired with free_vg and vg_free is already used
> for something else:)
> 
>> Also the location after Dave's refactoring patches is unclear.
>  
> vg.c  - move free_vg there too.
> 
>> +	if (!(vgmem = dm_pool_create("lvm2 vg_handle", VG_MEMPOOL_CHUNK)) ||
> 
> The code is now shared - "alloc_vg" will have to do, or if that makes
> the log too hard to understand, pass the existing strings into the function.

Ok - I'll add string arg to alloc_vg() for debug purposes.


Zdenek