From: Jens Lehmann <Jens.Lehmann@web.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Marc Branchaud <marcnarc@xiplink.com>,
Kevin Ballard <kevin@sb.org>, Heiko Voigt <hvoigt@hvoigt.net>
Subject: Re: [PATCH 0/6] Teach fetch/pull the on-demand mode and make it the default
Date: Thu, 24 Feb 2011 00:48:56 +0100 [thread overview]
Message-ID: <4D659CE8.3030604@web.de> (raw)
In-Reply-To: <20110223232156.GE6819@elie>
Am 24.02.2011 00:21, schrieb Jonathan Nieder:
> Jens Lehmann wrote:
>
>> *) The fetch is only done when the recorded submodule commit isn't
>> already present.
>
> I like this part a lot.
Glad to hear ;-)
>> I tend to think that this is suited for 1.7.5 but don't have any
>> objections against holding it back until 1.8.0 either. What do
>> others think?
>
> I see no backward-compatibility to wait for this, but I would be more
> included to trust people using "git submodule update" heavily than I
> do.
Yeah, I would appreciate some feedback here too.
> The "submodule update" change could cause the following to break.
> Would that be disruptive?
>
> cd submodule
> git fetch --no-recurse-submodules
> ...
>
> cd ..
> bin/script-to-update-submodules-that-calls-submodule-update
But then "git submodule update" would notice that the commit isn't
present and do a "git fetch" itself, no?
prev parent reply other threads:[~2011-02-23 23:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 20:33 [PATCH 0/6] Teach fetch/pull the on-demand mode and make it the default Jens Lehmann
2011-02-23 20:34 ` [PATCH 1/6] fetch/pull: recurse into submodules when necessary Jens Lehmann
2011-02-23 22:56 ` Junio C Hamano
2011-02-23 23:28 ` Jens Lehmann
2011-02-24 0:22 ` Jonathan Nieder
2011-02-23 23:07 ` Jonathan Nieder
2011-02-23 23:43 ` Jens Lehmann
2011-02-23 23:58 ` Jonathan Nieder
2011-02-23 20:35 ` [PATCH 2/6] fetch/pull: Add the 'on-demand' value to the --recurse-submodules option Jens Lehmann
2011-02-23 23:12 ` Jonathan Nieder
2011-02-23 23:14 ` Jonathan Nieder
2011-02-23 20:35 ` [PATCH 3/6] config: teach the fetch.recurseSubmodules option the 'on-demand' value Jens Lehmann
2011-02-23 20:36 ` [PATCH 4/6] Submodules: Add 'on-demand' value for the 'fetchRecurseSubmodule' option Jens Lehmann
2011-02-23 23:16 ` Junio C Hamano
2011-02-24 20:44 ` Jens Lehmann
2011-02-23 20:36 ` [PATCH 5/6] fetch/pull: Don't recurse into a submodule when commits are already present Jens Lehmann
2011-02-23 23:21 ` Junio C Hamano
2011-02-23 23:50 ` Jens Lehmann
2011-02-24 8:20 ` Jens Lehmann
2011-02-23 20:36 ` [PATCH 6/6] submodule update: Don't fetch when the submodule commit is " Jens Lehmann
2011-02-23 23:23 ` Junio C Hamano
2011-02-23 23:21 ` [PATCH 0/6] Teach fetch/pull the on-demand mode and make it the default Jonathan Nieder
2011-02-23 23:48 ` Jens Lehmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D659CE8.3030604@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=jrnieder@gmail.com \
--cc=kevin@sb.org \
--cc=marcnarc@xiplink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.