All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Thomas <gary@mlbassoc.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Poky <poky@lists.pokylinux.org>
Subject: Re: git and BB_NO_NETWORK
Date: Wed, 23 Feb 2011 17:29:07 -0700	[thread overview]
Message-ID: <4D65A653.2060204@mlbassoc.com> (raw)
In-Reply-To: <1298505424.26736.75.camel@rex>

On 02/23/2011 04:57 PM, Richard Purdie wrote:
> On Wed, 2011-02-23 at 08:19 -0700, Gary Thomas wrote:
>> This is related to bug #752
>>
>> Richard has made some changes which nearly fixes that bug, except
>> for the mtd-utils_1.4.1.bb recipe.  The problem with this recipe
>> is that it specifies a git tag, not a fixed revision.  The fetcher
>> fails in this case as it has to interrogate the git tree to find
>> the tag and that's not allowed because of BB_NO_NETWORK=1
>>
>> I tried to move this to a fixed revision which corresponds to tag v1.4.1
>> like this:
>>
>> diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb b/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb
>> index 5e6db0e..2c4e276 100644
>> --- a/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb
>> +++ b/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb
>> @@ -6,11 +6,12 @@ LICENSE = "GPLv2+"
>>    LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>>                        file://include/common.h;beginline=1;endline=17;md5=ba05b07912a44ea2bf81ce409380049c"
>>
>> -SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git;tag=v${PV} \
>> +SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git \
>>                   file://add-exclusion-to-mkfs-jffs2-git-2.patch;patch=1"
>>
>>    S = "${WORKDIR}/git/"
>>
>> +PV = "1.4.1${SRCPV}"
>>    PR = "r1"
>>
>>    EXTRA_OEMAKE = "'CC=${CC}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
>>
>> I also added this to my fixed-revisions.inc
>> SRCREV_pn-mtd-utils ??= "3c3674a6e1d3f59554b0ff68ca59be2fd4134e0c"
>>
>> Finally, I had to move recipes-devtools/mtd/mtd-utils-1.4.1/add-exclusion-to-mkfs-jffs2-git-2.patch
>> to recipes-devtools/mtd/mtd-utils or else it could not be found.
>>
>> Is there an easier way to solve these issues?  Once I understand the whole process, I can
>> propose a patch.
>
> I think these issues were discussed and resolved in the bugzilla?
>
> http://bugzilla.pokylinux.org/show_bug.cgi?id=752
>
> In future please try and keep the discussions in one place, not both, or
> state on the bugzilla you're moving it to email.

Of course.  Actually, it was the other way around, I first
send this to the list in case someone other than you (overworked,
I'm sure) had an idea.  I copied it to the bug just for reference.

Both bugs #752 & 753 seem to be taken care of now.

Thanks

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


      reply	other threads:[~2011-02-24  0:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-23 15:19 git and BB_NO_NETWORK Gary Thomas
2011-02-23 23:57 ` Richard Purdie
2011-02-24  0:29   ` Gary Thomas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D65A653.2060204@mlbassoc.com \
    --to=gary@mlbassoc.com \
    --cc=poky@lists.pokylinux.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.