From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v4 0/6] Add location-reporting atom
Date: Wed, 23 Feb 2011 18:55:26 -0600 [thread overview]
Message-ID: <4D65AC7E.5000804@gmail.com> (raw)
In-Reply-To: <1298399715-9617-1-git-send-email-lucas.demarchi@profusion.mobi>
[-- Attachment #1: Type: text/plain, Size: 1991 bytes --]
Hi Lucas,
On 02/22/2011 12:35 PM, Lucas De Marchi wrote:
> From: Lucas De Marchi <lucas.de.marchi@gmail.com>
>
> This is the 4th version of the location-reporting patches (previous title was
> "Add GPS atom"). I worked with Rafael Ignacio Zurita to implement this last
> version, making some changes in order to fit the new design as discussed on irc.
>
> Now when a client calls 'Request()' we give it a file
> descriptor in which the location reporting will be written. By checking the
> 'Type' property the client can decide what to do with such information. As of
> now only NMEA is supported and it's implemented on mbm modem.
>
> If client exits or calls 'Release()', the location reporting is disabled.
>
> Rafael Ignacio Zurita (6):
> location-reporting: add public header
> location-reporting: add atom implementation
> mbmmodem: add location-reporting driver implementation
> mbm: add location-reporting atom
> udev: add location-reporting device to mbm
> location-reporting: add documentation
>
> Makefile.am | 11 +-
> doc/location-reporting-api.txt | 39 ++++
> drivers/mbmmodem/location-reporting.c | 247 +++++++++++++++++++++
> drivers/mbmmodem/mbmmodem.c | 2 +
> drivers/mbmmodem/mbmmodem.h | 3 +
> include/location-reporting.h | 81 +++++++
> plugins/mbm.c | 8 +
> plugins/udev.c | 5 +-
> src/location-reporting.c | 393 +++++++++++++++++++++++++++++++++
> src/ofono.h | 2 +
> 10 files changed, 785 insertions(+), 6 deletions(-)
> create mode 100644 doc/location-reporting-api.txt
> create mode 100644 drivers/mbmmodem/location-reporting.c
> create mode 100644 include/location-reporting.h
> create mode 100644 src/location-reporting.c
>
So I applied all of these patches, however see my comments for patch 3.
Regards,
-Denis
prev parent reply other threads:[~2011-02-24 0:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 18:35 [PATCH v4 0/6] Add location-reporting atom Lucas De Marchi
2011-02-22 18:35 ` [PATCH v4 1/6] location-reporting: add public header Lucas De Marchi
2011-02-22 18:35 ` [PATCH v4 2/6] location-reporting: add atom implementation Lucas De Marchi
2011-02-22 18:35 ` [PATCH v4 3/6] mbmmodem: add location-reporting driver implementation Lucas De Marchi
2011-02-24 0:57 ` Denis Kenzior
2011-02-24 2:26 ` Lucas De Marchi
2011-02-24 4:21 ` Denis Kenzior
2011-02-22 18:35 ` [PATCH v4 4/6] mbm: add location-reporting atom Lucas De Marchi
2011-02-22 18:35 ` [PATCH v4 5/6] udev: add location-reporting device to mbm Lucas De Marchi
2011-02-22 18:35 ` [PATCH v4 6/6] location-reporting: add documentation Lucas De Marchi
2011-02-24 0:55 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D65AC7E.5000804@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.