From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshiaki Tamura Subject: Re: [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode. Date: Thu, 24 Feb 2011 12:54:33 +0900 Message-ID: <4D65D679.3010607@lab.ntt.co.jp> References: <1298468927-19193-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1298468927-19193-8-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kwolf@redhat.com, aliguori@us.ibm.com, dlaor@redhat.com, ananth@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com, ohmura.kei@lab.ntt.co.jp, avi@redhat.com, pbonzini@redhat.com, psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com To: quintela@redhat.com Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org Juan Quintela wrote: > Yoshiaki Tamura wrote: >> This code implements VM transaction protocol. Like buffered_file, it >> sits between savevm and migration layer. With this architecture, VM >> transaction protocol is implemented mostly independent from other >> existing code. > > Could you explain what is the difference with buffered_file.c? > I am fixing problems on buffered_file, and having something that copies > lot of code from there makes me nervous. The objective is different: buffered_file buffers data for transmission control. ft_trans_file adds headers to the stream, and controls the transaction between sender and receiver. Although ft_trans_file sometimes buffers date, but it's not the main objective. If you're fixing the problems on buffered_file, I'll keep eyes on them. >> +typedef ssize_t (FtTransPutBufferFunc)(void *opaque, const void *data, size_t size); > > Can we get some sharing here? > typedef ssize_t (BufferedPutFunc)(void *opaque, const void *data, size_t size); > > There are not so much types for a write function that the 1st element is > one opaque :p You're right, but I want to keep ft_trans_file independent of buffered_file at this point. Once Kemari gets merged, I'm happy to work with you to fix the problems on buffered_file and ft_trans_file, and refactoring them. Thanks, Yoshi > > Later, Juan. > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37906 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PsSHx-00085u-NB for qemu-devel@nongnu.org; Wed, 23 Feb 2011 22:54:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PsSHw-0000M4-B4 for qemu-devel@nongnu.org; Wed, 23 Feb 2011 22:54:49 -0500 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]:55557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PsSHv-0000LP-O0 for qemu-devel@nongnu.org; Wed, 23 Feb 2011 22:54:48 -0500 Message-ID: <4D65D679.3010607@lab.ntt.co.jp> Date: Thu, 24 Feb 2011 12:54:33 +0900 From: Yoshiaki Tamura MIME-Version: 1.0 References: <1298468927-19193-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1298468927-19193-8-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: kwolf@redhat.com, aliguori@us.ibm.com, dlaor@redhat.com, ananth@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com, ohmura.kei@lab.ntt.co.jp, avi@redhat.com, pbonzini@redhat.com, psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com Juan Quintela wrote: > Yoshiaki Tamura wrote: >> This code implements VM transaction protocol. Like buffered_file, it >> sits between savevm and migration layer. With this architecture, VM >> transaction protocol is implemented mostly independent from other >> existing code. > > Could you explain what is the difference with buffered_file.c? > I am fixing problems on buffered_file, and having something that copies > lot of code from there makes me nervous. The objective is different: buffered_file buffers data for transmission control. ft_trans_file adds headers to the stream, and controls the transaction between sender and receiver. Although ft_trans_file sometimes buffers date, but it's not the main objective. If you're fixing the problems on buffered_file, I'll keep eyes on them. >> +typedef ssize_t (FtTransPutBufferFunc)(void *opaque, const void *data, size_t size); > > Can we get some sharing here? > typedef ssize_t (BufferedPutFunc)(void *opaque, const void *data, size_t size); > > There are not so much types for a write function that the 1st element is > one opaque :p You're right, but I want to keep ft_trans_file independent of buffered_file at this point. Once Kemari gets merged, I'm happy to work with you to fix the problems on buffered_file and ft_trans_file, and refactoring them. Thanks, Yoshi > > Later, Juan. >