From: Paolo Bonzini <pbonzini@redhat.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] target-sh4: move intr_at_halt out of cpu_halted()
Date: Thu, 24 Feb 2011 13:05:02 +0100 [thread overview]
Message-ID: <4D66496E.70609@redhat.com> (raw)
In-Reply-To: <1298548457-10157-1-git-send-email-aurelien@aurel32.net>
On 02/24/2011 12:54 PM, Aurelien Jarno wrote:
> All targets except SH4 have the same cpu_halted() routine, and it has
> only one caller. It is therefore a good candidate for inlining.
>
> The difference is the handling of the intr_at_halt, which is necessary
> to ignore SR.BL when sleeping. Move intr_at_halt handling out of it, by
> setting this variable while executing the sleep instruction, and
> clearing it when the CPU has been woken-up by an interrupt, whatever the
> state of SR.BL.
>
> Cc: Paolo Bonzini<pbonzini@redhat.com>
> Signed-off-by: Aurelien Jarno<aurelien@aurel32.net>
Makes sense, thanks!
You may want to rename intr_at_halt to env->in_sleep or something like that.
Paolo
next prev parent reply other threads:[~2011-02-24 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 11:54 [Qemu-devel] [PATCH] target-sh4: move intr_at_halt out of cpu_halted() Aurelien Jarno
2011-02-24 12:05 ` Paolo Bonzini [this message]
2011-02-24 13:09 ` [Qemu-devel] " Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D66496E.70609@redhat.com \
--to=pbonzini@redhat.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.