From: Ferry Huberts <mailings@hupie.com>
To: Lars Hjemli <hjemli@gmail.com>
Cc: Git ML <git@vger.kernel.org>
Subject: Re: [CGit] [PATCH 0/6] Communicate the repo name to the filter scripts
Date: Thu, 24 Feb 2011 14:32:45 +0100 [thread overview]
Message-ID: <4D665DFD.6080802@hupie.com> (raw)
In-Reply-To: <AANLkTimASPjeHor3R6c=i1xpjftxrg4NnFaLJfReuZ-X@mail.gmail.com>
Lars,
I've put my repo on github: https://github.com/fhuberts/cgit
You can fetch my changes from there
Any idea on how to proceed?
On 02/19/2011 09:46 AM, Lars Hjemli wrote:
> On Thu, Feb 17, 2011 at 22:11, Ferry Huberts <mailings@hupie.com> wrote:
>> This patch series fixes two bugs and communicates the repo name
>> to the filter scripts.
>
> Thanks, but I think the current filter invocations with unnamed,
> positional command arguments was a mistake. We should probably fix it
> instead of extending it, taking care not to break backwards
> compatibility.
>
> The easiest fix would be to add some environment variables:
> * GIT_DIR
> * CGIT_REPO_NAME
> * CGIT_REPO_REL_URL
> * CGIT_REPO_ABS_URL
> * CGIT_BRANCH_NAME
> * CGIT_COMMIT_ID
> * CGIT_PATH_FILTER
>
> What do you think?
>
> --
> larsh
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
grtz
--
Ferry Huberts
prev parent reply other threads:[~2011-02-24 13:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 21:11 [CGit] [PATCH 0/6] Communicate the repo name to the filter scripts Ferry Huberts
2011-02-17 21:11 ` [CGit] [PATCH 1/6] source_filter: fix a memory leak Ferry Huberts
2011-02-17 21:11 ` [CGit] [PATCH 2/6] new_filter: correctly initialise all arguments for a new filter Ferry Huberts
2011-02-17 21:11 ` [CGit] [PATCH 3/6] new_filter: determine extra_args from filter type Ferry Huberts
2011-02-17 21:11 ` [CGit] [PATCH 4/6] source_filter: also communicate the repo name to the filter Ferry Huberts
2011-02-17 21:11 ` [CGit] [PATCH 5/6] commit_filter: " Ferry Huberts
2011-02-17 21:11 ` [CGit] [PATCH 6/6] about_filter: " Ferry Huberts
2011-02-17 21:23 ` [CGit] [PATCH 0/6] Communicate the repo name to the filter scripts Ferry Huberts
2011-02-19 8:46 ` Lars Hjemli
2011-02-19 13:54 ` Ferry Huberts
2011-02-24 13:32 ` Ferry Huberts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D665DFD.6080802@hupie.com \
--to=mailings@hupie.com \
--cc=git@vger.kernel.org \
--cc=hjemli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.