From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Subject: Re: [PATCH] Avoid race when moving cpu between cpupools Date: Thu, 24 Feb 2011 15:08:56 +0100 Message-ID: <4D666678.1000301@amd.com> References: <5485071c8b0a6a49f65b.1298541625@nehalem1> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5485071c8b0a6a49f65b.1298541625@nehalem1> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Juergen Gross , Keir Fraser Cc: Dunlap , "xen-devel@lists.xensource.com" George, "Diestelhorst, Stephan" List-Id: xen-devel@lists.xenproject.org Juergen Gross wrote: > Moving cpus between cpupools is done under the schedule lock of the moved cpu. > When checking a cpu being member of a cpupool this must be done with the lock > of that cpu being held. I have reviewed and tested the patch. It fixes my problem. My script has been running for several hundred iterations without any Xen crash, whereas without the patch the hypervisor crashed mostly at the second iteration. Thanks Juergen and George for the persistent work! > Hot-unplugging of physical cpus might encounter the same problems, but this > should happen only very rarely. > > Signed-off-by: juergen.gross@ts.fujitsu.com Acked-by: Andre Przywara Keir, please apply for 4.1.0. Regards, Andre. -- Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany