All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] stop and show registers on error.
Date: Thu, 24 Feb 2011 18:20:24 +0200	[thread overview]
Message-ID: <4D668548.3040807@redhat.com> (raw)
In-Reply-To: <20110221125757.GM14984@redhat.com>

On 02/21/2011 02:57 PM, Gleb Natapov wrote:
> >
> >  FWIW, this patch just aligns qemu-kvm to what upstream already does and
> >  what qemu-kvm will soon or later do as well when it starts using the
> >  upstream loop. I'm neutral /wrt applying this patch before the cleanup
> >  or achieving the same by consolidating the code.
> >
> Indeed. When I got no register dump on error I stared at the wrong code
> for 20 minutes trying to understand how it could happen. Having two kvm
> implementations in the same tree is such fun!

Very well, patch applied.

-- 
error compiling committee.c: too many arguments to function


      reply	other threads:[~2011-02-24 16:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-21 10:16 [PATCH] stop and show registers on error Gleb Natapov
2011-02-21 12:24 ` Avi Kivity
2011-02-21 12:25   ` Gleb Natapov
2011-02-21 12:53     ` Jan Kiszka
2011-02-21 12:57       ` Gleb Natapov
2011-02-24 16:20         ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D668548.3040807@redhat.com \
    --to=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.