From: Eric Sandeen <sandeen@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Yongqiang Yang <xiaoqiangnk@gmail.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4:Fix a bug in ext4_ext_fiemap_cb().
Date: Thu, 24 Feb 2011 10:34:32 -0600 [thread overview]
Message-ID: <4D668898.3020303@redhat.com> (raw)
In-Reply-To: <20110224000455.GN3166@dastard>
On 02/23/2011 06:04 PM, Dave Chinner wrote:
> This sound sort of problem indicateѕ to me that we need a generic
> fiemap test in xfstests that exercises all these corner cases.
> Perhaps something similar to the way I tested all the
> XFS_IOC_ZERO_RANGE corner cases in test 242 by setting up all the
> different hole/delalloc/unwritten/allocated combinations using
> xfs_io and used the fiemap output as the golden output?
>
> That would catch all of these problems in the different filesystems
> that implement fiemap and make sure we notice regressions pretty
> quickly.....
>
> Cheers,
>
> Dave.
Or, remove the "sync" calls from josef's fiemap tester:
fiemap->fm_flags = FIEMAP_FLAG_SYNC;
More random but would quickly blow up I bet.
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-24 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 15:59 [PATCH] ext4:Fix a bug in ext4_ext_fiemap_cb() Yongqiang Yang
2011-02-23 16:41 ` Eric Sandeen
2011-02-24 0:04 ` Dave Chinner
2011-02-24 16:34 ` Eric Sandeen [this message]
2011-02-24 0:33 ` Yongqiang Yang
2011-02-24 16:36 ` Eric Sandeen
2011-02-24 0:40 ` Yongqiang Yang
2011-02-24 0:56 ` Yongqiang Yang
2011-02-23 23:35 ` Andreas Dilger
2011-02-24 0:37 ` Yongqiang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D668898.3020303@redhat.com \
--to=sandeen@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.