All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] stk: Add null pointer check
Date: Fri, 25 Feb 2011 11:58:23 -0600	[thread overview]
Message-ID: <4D67EDBF.4060701@gmail.com> (raw)
In-Reply-To: <AANLkTik8FOtSTWfyATp_eXV-7Prp9+Ao3BA1NBNoJMnm@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Hi Andrew / Lasse,

> diff --git a/src/stk.c b/src/stk.c
> index bc46b2f..c4e988b 100644
> --- a/src/stk.c
> +++ b/src/stk.c
> @@ -2514,6 +2514,7 @@ static void stk_proactive_command_cancel(struct
> ofono_stk *stk)
>                 stk_command_free(stk->pending_cmd);
>                 stk->pending_cmd = NULL;
>                 stk->cancel_cmd = NULL;
> +               stk->respond_on_exit = FALSE;
>         }
>  }
> 

Patch looks good to me, however I'd like it in something I can actually
apply.

Lasse, can you confirm this patch solves your issue?

Regards,
-Denis

  reply	other threads:[~2011-02-25 17:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-25 10:39 [PATCH] stk: Add null pointer check Lasse Kunnasluoto
2011-02-25 12:39 ` Andrzej Zaborowski
2011-02-25 13:04   ` Lasse Kunnasluoto
2011-02-25 13:28     ` Andrzej Zaborowski
2011-02-25 17:58       ` Denis Kenzior [this message]
2011-02-28  9:50         ` Lasse Kunnasluoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D67EDBF.4060701@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.