From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7461335682091740327==" MIME-Version: 1.0 From: Denis Kenzior Subject: Re: [PATCH 1/2] Clean up isi_call_any_address_sb_proc Date: Fri, 25 Feb 2011 12:43:35 -0600 Message-ID: <4D67F857.3070306@gmail.com> In-Reply-To: <1298653824-25127-1-git-send-email-a.reversat@gmail.com> List-Id: To: ofono@ofono.org --===============7461335682091740327== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Antoine, On 02/25/2011 11:10 AM, Antoine Reversat wrote: > --- > drivers/isimodem/voicecall.c | 11 +++++++---- > 1 files changed, 7 insertions(+), 4 deletions(-) > = > diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c > index 0a32f27..0ad4dfb 100644 > --- a/drivers/isimodem/voicecall.c > +++ b/drivers/isimodem/voicecall.c > @@ -210,10 +210,13 @@ static void isi_call_any_address_sb_proc(struct isi= _voicecall *ivc, > uint8_t len; > char *addr; > = > - if (!g_isi_sb_iter_get_byte(sb, &type, 2) || > - !g_isi_sb_iter_get_byte(sb, &pres, 3) || > - !g_isi_sb_iter_get_byte(sb, &len, 5) || > - !g_isi_sb_iter_get_alpha_tag(sb, &addr, 2 * len, 6)) > + if (!g_isi_sb_iter_get_byte(sb, &type, 2)) > + return; > + if (!g_isi_sb_iter_get_byte(sb, &pres, 3)) > + return; > + if (!g_isi_sb_iter_get_byte(sb, &len, 5)) > + return; > + if (!g_isi_sb_iter_get_alpha_tag(sb, &addr, 2 * len, 6)) > return; This is indeed the preferred structure, however please note doc/coding-style.txt rule M1. > = > call->addr_type =3D type | 0x80; Regards, -Denis --===============7461335682091740327==--