From: "H. Peter Anvin" <hpa@zytor.com>
To: Stratos Psomadakis <psomas@cslab.ece.ntua.gr>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH RESEND 1/1] Cleanup of asm-offsets.c(PAGE_SIZE_asm, PAGE_SHIFT_asm, THREAD_SIZE_asm)
Date: Fri, 25 Feb 2011 12:20:23 -0800 [thread overview]
Message-ID: <4D680F07.1070709@zytor.com> (raw)
In-Reply-To: <1298664220-21548-2-git-send-email-psomas@cslab.ece.ntua.gr>
On 02/25/2011 12:03 PM, Stratos Psomadakis wrote:
> Cleanup of asm-offsets.c.
>
> PAGE_SIZE_asm, PAGE_SHIFT_asm, THREAD_SIZE_asm can be safely removed from
> asm-offsets.c, and be replaced by their non-'_asm' counterparts in the code
> that uses them, since the _AC macro defined in include/linux/const.h makes
> PAGE_SIZE/PAGE_SHIFT/THREAD_SIZE work with as.
>
> Signed-off-by: Stratos Psomadakis <psomas@cslab.ece.ntua.gr>
> ---
> arch/mn10300/kernel/asm-offsets.c | 2 --
> arch/mn10300/kernel/gdb-io-ttysm-low.S | 2 +-
> arch/x86/kernel/asm-offsets_32.c | 4 ----
> arch/x86/kernel/asm-offsets_64.c | 1 -
> arch/x86/kernel/entry_32.S | 2 +-
> arch/x86/kernel/head_32.S | 8 ++++----
> arch/x86/xen/xen-head.S | 4 ++--
> 7 files changed, 8 insertions(+), 15 deletions(-)
>
Looks good, but please separate the mn10300 and x86 chunks into separate
patches.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2011-02-25 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 14:42 [PATCH] Cleanup of asm-offsets.c(PAGE_SIZE_asm, PAGE_SHIFT_asm, THREAD_SIZE_asm) Stratos Psomadakis
2011-02-24 23:21 ` Steven Rostedt
2011-02-25 20:03 ` [PATCH RESEND 0/1] " Stratos Psomadakis
2011-02-25 20:03 ` [PATCH RESEND 1/1] " Stratos Psomadakis
2011-02-25 20:20 ` H. Peter Anvin [this message]
2011-02-25 20:46 ` [PATCH SPLIT 0/2] Cleanup " Stratos Psomadakis
2011-02-25 20:46 ` [PATCH 1/2] Cleanup x86 " Stratos Psomadakis
2011-02-26 6:34 ` [tip:x86/asm] x86, asm: Cleanup unnecssary macros in asm-offsets.c tip-bot for Stratos Psomadakis
2011-02-25 20:46 ` [PATCH 2/2] Cleanup mn10300 asm-offsets.c(PAGE_SIZE_asm) Stratos Psomadakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D680F07.1070709@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=psomas@cslab.ece.ntua.gr \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.