From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by mx1.pokylinux.org (Postfix) with ESMTP id 045574C800AC for ; Fri, 25 Feb 2011 15:31:38 -0600 (CST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 25 Feb 2011 13:31:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.62,227,1297065600"; d="scan'208";a="394257723" Received: from unknown (HELO [10.255.12.120]) ([10.255.12.120]) by azsmga001.ch.intel.com with ESMTP; 25 Feb 2011 13:31:38 -0800 Message-ID: <4D681FB9.9090200@intel.com> Date: Fri, 25 Feb 2011 13:31:37 -0800 From: Saul Wold User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5 MIME-Version: 1.0 To: Joshua Lock References: <82d3ef44b338806b0af4b4fdbcab54f15108b0e5.1298661117.git.josh@linux.intel.com> <4D681066.3040700@windriver.com> <1298669236.11134.5.camel@scimitar> In-Reply-To: <1298669236.11134.5.camel@scimitar> Cc: poky@yoctoproject.org Subject: Re: [PATCH 1/3] base.bbclass: enable INCOMPATIBLE_LICENSE to match slight variations X-BeenThere: poky@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Poky build system developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2011 21:31:39 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 02/25/2011 01:27 PM, Joshua Lock wrote: > On Fri, 2011-02-25 at 14:26 -0600, Mark Hatle wrote: >> Only thing I would be concerned with in this patch is a license of "GPLv3 w/ >> exception" (I'm not sure how we address that, but there are cases where things >> are GPLv3, but the exception may allow someone to use the component where they >> would not normally allow for GPLv3.) I'm not exactly sure the best way to >> handle this... > > Hmm, fair point - I hadn't thought of that. > > I can't think of a better way to do this that doesn't involve > implementing a fragile test, in which case we'd probably best ignore > this and patch three from this series. > I was also looking at this, and wondering if it was appropriate, so you only want me to pull patch 2 of this set? Patch 3 is still sort of appropriate, that's what I set for my testing right now. But as Mark points out it's far from perfect and right now I am having failures building without GPLv3! Sau! > Cheers, > Joshua >> >> --Mark >> >> On 2/25/11 1:13 PM, Joshua Lock wrote: >>> From: Joshua Lock >>> >>> Add a greedy any-character match to INCOMPATIBLE_LICENSE so that we can match >>> different permutations of that license, i.e. if INCOMPATIBLE_LICENSE is set >>> to GPLv3 we should also match GPLv3+ >>> >>> Signed-off-by: Joshua Lock >>> --- >>> meta/classes/base.bbclass | 9 ++++++++- >>> 1 files changed, 8 insertions(+), 1 deletions(-) >>> >>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass >>> index a674f52..3ff11d3 100644 >>> --- a/meta/classes/base.bbclass >>> +++ b/meta/classes/base.bbclass >>> @@ -345,7 +345,14 @@ python () { >>> raise bb.parse.SkipPackage("incompatible with machine %s" % this_machine) >>> >>> >>> - dont_want_license = bb.data.getVar('INCOMPATIBLE_LICENSE', d, 1) >>> + dont_want_license = bb.data.getVar('INCOMPATIBLE_LICENSE', d, True) >>> + # If dont_want_license is set add a greedy any-character match >>> + # to it (if not already set) so that we can match permutations >>> + # of that license. i.e. if dont_want_license is set to GPLv3 we >>> + # also want to match GPLv3+ >>> + if dont_want_license and not dont_want_license.endswith('.+'): >>> + dont_want_license = dont_want_license + '.+' >>> + >>> if dont_want_license and not pn.endswith("-native") and not pn.endswith("-cross") and not pn.endswith("-cross-initial") and not pn.endswith("-cross-intermediate"): >>> hosttools_whitelist = (bb.data.getVar('HOSTTOOLS_WHITELIST_%s' % dont_want_license, d, 1) or "").split() >>> lgplv2_whitelist = (bb.data.getVar('LGPLv2_WHITELIST_%s' % dont_want_license, d, 1) or "").split() >> >> _______________________________________________ >> poky mailing list >> poky@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/poky >