All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Coopersmith <alan.coopersmith@oracle.com>
To: Sedat Dilek <sedat.dilek@googlemail.com>
Cc: Sedat Dilek <sedat.dilek@gmail.com>,
	xorg-driver-ati@lists.x.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] kms: Fix warning XNFprintf is deprecated
Date: Fri, 25 Feb 2011 14:32:43 -0800	[thread overview]
Message-ID: <4D682E0B.6070704@oracle.com> (raw)
In-Reply-To: <1298668038-16374-1-git-send-email-sedat.dilek@gmail.com>

On 02/25/11 01:07 PM, Sedat Dilek wrote:
> Noticed when building ati/radeon ddx against xserver 1.10-rc3.
> 
> [ build.log ]
> ../../src/radeon_kms.c:412:5: warning: 'XNFprintf' is deprecated (declared at /usr/include/xorg/os.h:273)
> 
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
> ---
>  src/radeon_kms.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/radeon_kms.c b/src/radeon_kms.c
> index 158dc57..19b0c74 100644
> --- a/src/radeon_kms.c
> +++ b/src/radeon_kms.c
> @@ -409,7 +409,7 @@ static Bool radeon_open_drm_master(ScrnInfoPtr pScrn)
>  	goto out;
>      }
>  
> -    busid = XNFprintf("pci:%04x:%02x:%02x.%d",
> +    busid = XNFasprintf("pci:%04x:%02x:%02x.%d",

A straight replacement like that, with no #ifdef's will break people building
for Xorg 1.9 and older, since XNFasprintf is new in Xorg 1.10.

-- 
	-Alan Coopersmith-        alan.coopersmith@oracle.com
	 Oracle Solaris Platform Engineering: X Window System

  reply	other threads:[~2011-02-25 22:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-25 21:07 [PATCH] kms: Fix warning XNFprintf is deprecated Sedat Dilek
2011-02-25 22:32 ` Alan Coopersmith [this message]
2011-02-26 17:08   ` Alan Coopersmith
2011-02-26 20:05     ` Sedat Dilek
     [not found] ` <1298668038-16374-1-git-send-email-sedat.dilek-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-02-25 23:20   ` Alex Deucher
2011-02-26 14:32 ` Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D682E0B.6070704@oracle.com \
    --to=alan.coopersmith@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sedat.dilek@gmail.com \
    --cc=sedat.dilek@googlemail.com \
    --cc=xorg-driver-ati@lists.x.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.