Re: [PATCH 1/2] lpfc: force retry in queuecommand when port is transitioning

[James Smart <james.smart@emulex.com>]

Acked-by: James Smart  <james.smart@emulex.com>

-- james s


On 2/25/2011 3:04 PM, michaelc@cs.wisc.edu wrote:
> From: Mike Christie<michaelc@cs.wisc.edu>
>
> If the port takes a while to transition we could exhaust
> the retries when using DID_TRANSPORT_DISRUPTED. For this
> case we do not want to use any of the cmd's
> retries, because if the command was running then when
> it got failed the retry counter was already incremented.
> And if this is the first time we are seeing the command,
> (it got queued because it slipped through during the race)
> then it should not have its retries incremented. The
> fc class will decide the correct handling later.
>
> Signed-off-by: Mike Christie<michaelc@cs.wisc.edu>
> ---
>   drivers/scsi/lpfc/lpfc_scsi.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
> index c97751c..af5aaaa 100644
> --- a/drivers/scsi/lpfc/lpfc_scsi.c
> +++ b/drivers/scsi/lpfc/lpfc_scsi.c
> @@ -3004,7 +3004,7 @@ lpfc_queuecommand_lck(struct scsi_cmnd *cmnd, void (*done) (struct scsi_cmnd *))
>   	 * transport is still transitioning.
>   	 */
>   	if (!ndlp || !NLP_CHK_NODE_ACT(ndlp)) {
> -		cmnd->result = ScsiResult(DID_TRANSPORT_DISRUPTED, 0);
> +		cmnd->result = ScsiResult(DID_IMM_RETRY, 0);
>   		goto out_fail_command;
>   	}
>   	if (atomic_read(&ndlp->cmd_pending)>= ndlp->cmd_qdepth)