[Qemu-devel] Re: [PATCH v2 uq/master 00/22] Win32 iothread support

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1449 bytes --]

On 2011-02-26 16:39, Paolo Bonzini wrote:
> After gathering the comments about the two series I sent separately,
> here is the full series for Win32 iothread support, ready to be
> applied to uq/master.
> 
> Patches 1 to 5 are generic Win32 improvements, including the qemu-thread
> implementation.  Because of complex dependencies, I think it's better
> if this part is also routed through uq/master.

Agreed. This also ensures that the non-Win32 parts receive autotest
blessing before being applied.

> 
> Patches 6 to 8 are generic threading improvements, including using
> PTHREAD_MUTEX_ERRORCHECK as suggested by Jan.
> 
> Patches 9 to 17 eliminate polling, replacing condition variable
> timedwait with wait.
> 
> Patch 18 removes a redundant condition from the TCG cpu_exec_all
> function.
> 
> Patches 19 to 21 add all necessary stubs to make iothread compile
> with Win32, except the IPI calls.  These are provided by patch 22.
> 
> Tested on Wine and Linux, not on "real" Windows.  The series introduces
> a dependency on Windows 2K or newer.  I don't think either 95/98/ME
> or Windows NT 3.x are reasonable host systems for QEMU, anyway.
> 
> I incorporated all suggestions from Jan, including his renaming patch
> for qemu_*_is_self, and included Aurelien's sh4 tweak to cpu_halted.
> 

#ifndef _WIN32
    Except for the minor remarks, looks very good to me.
#else
    Can't asses.
#endif

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]