From: Xiangfu Liu <xiangfu@openmobilefree.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 1/8] those files are jz4740 base files
Date: Mon, 28 Feb 2011 12:54:40 +0800 [thread overview]
Message-ID: <4D6B2A90.3070706@openmobilefree.net> (raw)
In-Reply-To: <20110117213500.DEA79D1CAD5@gemini.denx.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Wolfgang Denk
On 01/18/2011 05:35 AM, Wolfgang Denk wrote:
> Please do not use base + offset notation. Declare a proper C struct
> instead. Please fix globally.
>
>> > + /* Disable port interrupts while changing hardware */
>> > + *uart_ier = 0;
> And use proper I/O accessors to access device registers. Please fix
> globally.
I have delete all base + offset. using C struct now. and using proper I/O accressors
>
> ...
>> > +static ulong timestamp;
>> > +static ulong lastdec;
> As already has been pointed out several times before: this will not
> work because BSS cannot be accessed before relocation.
>
>
can you give me some tips how to fix this?
thanks
- --
Best Regards
Xiangfu Liu
http://www.openmobilefree.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk1rKpAACgkQRRAEFRxkgLTsFwCbBXgBNGik7HRZpdqEaUGQWni4
F4oAnjCE/5HzHaTt8Rn1lSziHKhpGQyv
=ILT1
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-02-28 4:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-09 16:18 [U-Boot] [PATCH v5 0/8] those series patches for add ben nanonote board Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 1/8] those files are jz4740 base files Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 2/8] this is jz4740 head file Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 3/8] jz4740 nand spl files Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 4/8] jz4740 nand driver Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 5/8] add Ben NanoNote board Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 6/8] add entry to MAINTAINERS and boards.cfg Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 7/8] modify files for ben nanonote board Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 8/8] add software usbboot Xiangfu Liu
2011-01-17 21:36 ` [U-Boot] [PATCH v5 2/8] this is jz4740 head file Wolfgang Denk
2011-01-17 21:35 ` [U-Boot] [PATCH v5 1/8] those files are jz4740 base files Wolfgang Denk
2011-02-28 4:54 ` Xiangfu Liu [this message]
2011-02-28 6:36 ` Xiangfu Liu
2011-01-10 13:33 ` [U-Boot] [PATCH v5 0/8] those series patches for add ben nanonote board Shinya Kuribayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6B2A90.3070706@openmobilefree.net \
--to=xiangfu@openmobilefree.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.