From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minkyu Kang Subject: Re: [PATCH] ARM: EXYNOS4: Adds Samsung NURI board support Date: Mon, 28 Feb 2011 17:14:01 +0900 Message-ID: <4D6B5949.8020606@samsung.com> References: <4D676BB8.9040803@samsung.com> <002301cbd71b$1969bd00$4c3d3700$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <002301cbd71b$1969bd00$4c3d3700$%kim@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Kukjin Kim Cc: kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org RGVhciBLdWtqaW4gS2ltLAoKMjAxMS0wMi0yOCDsmKTtm4QgNDo0MiwgS3VramluIEtpbSDsk7Qg 6riAOgo+IE1pbmt5dSBLYW5nIHdyb3RlOgo+Pgo+PiBUaGlzIHBhdGNoIGFkZHMgU2Ftc3VuZyBO VVJJIGJvYXJkIHN1cHBvcnQuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE1pbmt5dSBLYW5nIDxtazcu a2FuZ0BzYW1zdW5nLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogS3l1bmdtaW4gUGFyayA8a3l1bmdt aW4ucGFya0BzYW1zdW5nLmNvbT4KPj4gLS0tCj4+IFRoaXMgcGF0Y2ggaXMgYmFzZSBvbiBuZXh0 LWV4eW5vczQgYnJhbmNoIGF0IGtnZW5lIHRyZWUuCj4+Cj4+ICBhcmNoL2FybS9jb25maWdzL2V4 eW5vczRfZGVmY29uZmlnIHwgICAgMSArCj4+ICBhcmNoL2FybS9tYWNoLWV4eW5vczQvS2NvbmZp ZyAgICAgIHwgICAxNSArKysKPj4gIGFyY2gvYXJtL21hY2gtZXh5bm9zNC9NYWtlZmlsZSAgICAg fCAgICAxICsKPj4gIGFyY2gvYXJtL21hY2gtZXh5bm9zNC9tYWNoLW51cmkuYyAgfCAgMjMzCj4+ ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+PiAgNCBmaWxlcyBjaGFuZ2Vk LCAyNTAgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKPj4gIGNyZWF0ZSBtb2RlIDEwMDY0 NCBhcmNoL2FybS9tYWNoLWV4eW5vczQvbWFjaC1udXJpLmMKPj4KPiAKPj4gK2VudW0gZml4ZWRf cmVndWxhdG9yX2lkIHsKPj4gKwlGSVhFRF9SRUdfSURfTU1DID0gMCwKPiAKPiAJRklYRURfUkVH X0lEX01NQywKPiAKPiAoc25pcCkKPiAKPj4gK3N0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl IGVtbWNfZml4ZWRfdm9sdGFnZSA9IHsKPj4gKwkubmFtZQkJCT0gInJlZy1maXhlZC12b2x0YWdl IiwKPj4gKwkuaWQJCQk9IEZJWEVEX1JFR19JRF9NTUMsCj4gCj4gSXMgdGhlcmUgYW55IHJlYXNv biB0byB1c2UgRklYRURfUkVHX0lEX01NQyBpbnN0ZWFkIGRpcmVjdGx5IGlkIDA/Cj4gCgpJJ20g Z29pbmcgdG8gYWRkIG1vcmUgSURzIG9mIGZpeGVkIHJlZ3VsYXRvciB0aGF0IGFyZSBMQ0QgYW5k IEJhY2tsaWdodCwgYW5kIHNvIG9uLgpTbyB1c2UgZW51bSB2YWx1ZXMgZm9yIGF2b2lkIHRoZSBo YXJkIGNvZGluZy4KClRoYW5rcy4KTWlua3l1IEthbmcuCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mk7.kang@samsung.com (Minkyu Kang) Date: Mon, 28 Feb 2011 17:14:01 +0900 Subject: [PATCH] ARM: EXYNOS4: Adds Samsung NURI board support In-Reply-To: <002301cbd71b$1969bd00$4c3d3700$%kim@samsung.com> References: <4D676BB8.9040803@samsung.com> <002301cbd71b$1969bd00$4c3d3700$%kim@samsung.com> Message-ID: <4D6B5949.8020606@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Kukjin Kim, 2011-02-28 ?? 4:42, Kukjin Kim ? ?: > Minkyu Kang wrote: >> >> This patch adds Samsung NURI board support. >> >> Signed-off-by: Minkyu Kang >> Signed-off-by: Kyungmin Park >> --- >> This patch is base on next-exynos4 branch at kgene tree. >> >> arch/arm/configs/exynos4_defconfig | 1 + >> arch/arm/mach-exynos4/Kconfig | 15 +++ >> arch/arm/mach-exynos4/Makefile | 1 + >> arch/arm/mach-exynos4/mach-nuri.c | 233 >> ++++++++++++++++++++++++++++++++++++ >> 4 files changed, 250 insertions(+), 0 deletions(-) >> create mode 100644 arch/arm/mach-exynos4/mach-nuri.c >> > >> +enum fixed_regulator_id { >> + FIXED_REG_ID_MMC = 0, > > FIXED_REG_ID_MMC, > > (snip) > >> +static struct platform_device emmc_fixed_voltage = { >> + .name = "reg-fixed-voltage", >> + .id = FIXED_REG_ID_MMC, > > Is there any reason to use FIXED_REG_ID_MMC instead directly id 0? > I'm going to add more IDs of fixed regulator that are LCD and Backlight, and so on. So use enum values for avoid the hard coding. Thanks. Minkyu Kang.