From: Dimitris Michailidis <dm@chelsio.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: linux-scsi@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] cxgb{3,4}*: improve Kconfig dependencies
Date: Tue, 01 Mar 2011 01:10:10 -0800 [thread overview]
Message-ID: <4D6CB7F2.9020902@chelsio.com> (raw)
In-Reply-To: <4D6CB26802000078000343BD@vpn.id2.novell.com>
Jan Beulich wrote:
>>>> On 01.03.11 at 04:34, Dimitris Michailidis <dm@chelsio.com> wrote:
>> - Remove the dependency of cxgb4 and cxgb4vf on INET. cxgb3 really
>> depends on INET, keep it but add it directly to the driver's Kconfig
>> entry.
>> - Make the iSCSI drivers cxgb3i and cxgb4i available in the SCSI menu
>> without requiring any options in the net driver menu to be enabled
>> first. Add needed selects so the iSCSI drivers can build their
>> corresponding net drivers.
>> - Remove CHELSIO_T*_DEPENDS.
>>
>> Signed-off-by: Dimitris Michailidis <dm@chelsio.com>
>> ---
>> drivers/net/Kconfig | 21 +++------------------
>> drivers/scsi/cxgbi/cxgb3i/Kconfig | 4 +++-
>> drivers/scsi/cxgbi/cxgb4i/Kconfig | 4 +++-
>> 3 files changed, 9 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index f4b3927..6e09d5f 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -2595,14 +2595,9 @@ config CHELSIO_T1_1G
>> Enables support for Chelsio's gigabit Ethernet PCI cards. If you
>> are using only 10G cards say 'N' here.
>>
>> -config CHELSIO_T3_DEPENDS
>> - tristate
>> - depends on PCI && INET
>> - default y
>> -
>> config CHELSIO_T3
>> tristate "Chelsio Communications T3 10Gb Ethernet support"
>> - depends on CHELSIO_T3_DEPENDS
>> + depends on PCI && INET
>
> Forgot to remove INET here?
Didn't forget it, this driver has a real dependency on INET (ARP more
specifically). I mentioned it also in the commit message.
next prev parent reply other threads:[~2011-03-01 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 3:34 [PATCH] cxgb{3,4}*: improve Kconfig dependencies Dimitris Michailidis
2011-03-01 7:46 ` Jan Beulich
2011-03-01 7:46 ` Jan Beulich
2011-03-01 9:10 ` Dimitris Michailidis [this message]
2011-03-01 9:33 ` Jan Beulich
2011-03-01 9:33 ` Jan Beulich
2011-03-03 6:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6CB7F2.9020902@chelsio.com \
--to=dm@chelsio.com \
--cc=JBeulich@novell.com \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.