[PATCH 4/6] ARM: s5pv310: update IRQ combiner to use EOI in parent chip

[sshtylyov@mvista.com (Sergei Shtylyov)]

On 28-02-2011 16:33, Will Deacon wrote:

> The IRQ combiner code invokes the ->irq_{un}mask routines of the parent
> chip.

> This patch updates the cascaded handler to use EOI now that the GIC has
> moved to using the fasteoi flow model.

> Tested-by: Kyungmin Park<kyungmin.park@samsung.com>
> Signed-off-by: Will Deacon<will.deacon@arm.com>
> ---
>   arch/arm/mach-s5pv310/irq-combiner.c |    7 ++-----
>   1 files changed, 2 insertions(+), 5 deletions(-)

> diff --git a/arch/arm/mach-s5pv310/irq-combiner.c b/arch/arm/mach-s5pv310/irq-combiner.c
> index 1ea4a9e..24d5604 100644
> --- a/arch/arm/mach-s5pv310/irq-combiner.c
> +++ b/arch/arm/mach-s5pv310/irq-combiner.c
> @@ -59,9 +59,6 @@ static void combiner_handle_cascade_irq(unsigned int irq, struct irq_desc *desc)
>   	unsigned int cascade_irq, combiner_irq;
>   	unsigned long status;
>
> -	/* primary controller ack'ing */
> -	chip->irq_ack(&desc->irq_data);
> -

    Same question about bisectability here...

WBR, Sergei