From: Lars-Peter Clausen <lars@metafoo.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/6] FBDEV: JZ4740: Initialize jzfb->fb earlier
Date: Tue, 01 Mar 2011 13:58:13 +0000 [thread overview]
Message-ID: <4D6CFB75.909@metafoo.de> (raw)
In-Reply-To: <80cfeb81c3b4bae96f8ade317a08566c87493578.1298980528.git.mcuelenaere@gmail.com>
On 03/01/2011 01:05 PM, Maurus Cuelenaere wrote:
> There's no reason to not do this, and this is needed in the upcoming SLCD
> support patches.
>
Is there any specific reason, why this change can't be done in the patch adding
SLCD support?
- Lars
> Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
> ---
> drivers/video/jz4740_fb.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/jz4740_fb.c b/drivers/video/jz4740_fb.c
> index 65741d0..cea7b7e 100644
> --- a/drivers/video/jz4740_fb.c
> +++ b/drivers/video/jz4740_fb.c
> @@ -654,6 +654,7 @@ static int __devinit jzfb_probe(struct platform_device *pdev)
> fb->flags = FBINFO_DEFAULT;
>
> jzfb = fb->par;
> + jzfb->fb = fb;
> jzfb->pdev = pdev;
> jzfb->pdata = pdata;
> jzfb->mem = mem;
> @@ -722,8 +723,6 @@ static int __devinit jzfb_probe(struct platform_device *pdev)
> goto err_free_devmem;
> }
>
> - jzfb->fb = fb;
> -
> return 0;
>
> err_free_devmem:
next prev parent reply other threads:[~2011-03-01 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 12:05 [PATCH 2/6] FBDEV: JZ4740: Initialize jzfb->fb earlier Maurus Cuelenaere
2011-03-01 13:58 ` Lars-Peter Clausen [this message]
2011-03-01 17:19 ` Maurus Cuelenaere
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6CFB75.909@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.