From: Martyn Welch <martyn.welch@ge.com>
To: Manohar Vanga <manohar.vanga@cern.ch>
Cc: gregkh@suse.de, wfp5p@virginia.edu, cota@braap.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: vme: remove unreachable code
Date: Tue, 01 Mar 2011 15:34:32 +0000 [thread overview]
Message-ID: <4D6D1208.6020001@ge.com> (raw)
In-Reply-To: <1298759775-7822-2-git-send-email-manohar.vanga@cern.ch>
On 26/02/11 22:36, Manohar Vanga wrote:
> Remove some unreachable code (kfree calls) from vme.c
>
> Signed-off-by: Manohar Vanga <manohar.vanga@cern.ch>
Acked-by: Martyn Welch <martyn.welch@ge.com>
> ---
> drivers/staging/vme/vme.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
> index d9fc864..bbf58dc 100644
> --- a/drivers/staging/vme/vme.c
> +++ b/drivers/staging/vme/vme.c
> @@ -441,7 +441,6 @@ struct vme_resource *vme_master_request(struct device *dev,
>
> return resource;
>
> - kfree(resource);
> err_alloc:
> /* Unlock image */
> spin_lock(&master_image->lock);
> @@ -768,7 +767,6 @@ struct vme_dma_attr *vme_dma_pattern_attribute(u32 pattern,
>
> return attributes;
>
> - kfree(pattern_attr);
> err_pat:
> kfree(attributes);
> err_attr:
> @@ -809,7 +807,6 @@ struct vme_dma_attr *vme_dma_pci_attribute(dma_addr_t address)
>
> return attributes;
>
> - kfree(pci_attr);
> err_pci:
> kfree(attributes);
> err_attr:
> @@ -851,7 +848,6 @@ struct vme_dma_attr *vme_dma_vme_attribute(unsigned long long address,
>
> return attributes;
>
> - kfree(vme_attr);
> err_vme:
> kfree(attributes);
> err_attr:
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square, Manchester,
E martyn.welch@ge.com | M2 3AB VAT:GB 927559189
next prev parent reply other threads:[~2011-03-01 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 22:36 [PATCH 0/1] staging: vme: remove unreachable code Manohar Vanga
2011-02-26 22:36 ` [PATCH 1/1] " Manohar Vanga
2011-03-01 15:34 ` Martyn Welch [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-26 23:15 [PATCH 0/1] staging: vme: remove some more " Manohar Vanga
2011-02-26 23:15 ` [PATCH 1/1] staging: vme: remove " Manohar Vanga
2011-03-01 15:35 ` Martyn Welch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6D1208.6020001@ge.com \
--to=martyn.welch@ge.com \
--cc=cota@braap.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@cern.ch \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.