From: Anthony Liguori <anthony@codemonkey.ws>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
Ananth Narayan <ananth@linux.vnet.ibm.com>,
Prerna Saxena <prerna@linux.vnet.ibm.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [RFC][PATCH 0/2] Allow cache settings for block devices to be changed at runtime.
Date: Tue, 01 Mar 2011 10:47:38 -0500 [thread overview]
Message-ID: <4D6D151A.8080502@codemonkey.ws> (raw)
In-Reply-To: <4D6CF32C.4090709@redhat.com>
On 03/01/2011 08:22 AM, Kevin Wolf wrote:
>> Certainly good questions, but let me suggest not taking an HMP command
>> and not a QMP commans because of interface concerns.
>>
>> My goal for 0.15 is to convert HMP to be implemented in terms of QMP.
>> To do that, a bunch of new QMP commands are needed. They all won't be
>> perfect but i'd rather support a bad QMP command forever than to
>> continue to/ have people rely on HMP.
>>
> Okay, makes sense. So we should reject patches that add new HMP commands
> without adding a QMP counterpart.
>
Definitely. We essentially are supporting HMP today just as much as QMP
but HMP is much harder to support (no standard way to interpret
input/output/errors).
>>>> I agree that the guest should control the
>>>> emulated drive cache at runtime and we probably don't want to allow
>>>> toggling that from the host - it could be dangerous :).
>>>>
>>> Good point. That's a NACK for this patch as long as we haven't separated
>>> WCE from the host cache setting.
>>>
> Doesn't make a difference for this one, though, because it's NACKed anyway.
>
> Kevin
>
> PS: Anthony, is there a specific reason why you started sending HTML emails?
>
Because I was stuck using my phone because of bad hotel wireless :-/
Regards,
Anthony Liguori
next prev parent reply other threads:[~2011-03-01 15:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 11:49 [Qemu-devel] [RFC][PATCH 0/2] Allow cache settings for block devices to be changed at runtime Prerna Saxena
2011-02-28 12:07 ` [Qemu-devel] [RFC][PATCH 1/2] Add monitor command 'set-cache' to change cache settings for a block device Prerna Saxena
2011-02-28 12:11 ` [Qemu-devel] [RFC][PATCH 2/2] Extend monitor command 'info block' to display cache settings for block devices Prerna Saxena
2011-02-28 15:15 ` Kevin Wolf
2011-02-28 15:12 ` [Qemu-devel] [RFC][PATCH 0/2] Allow cache settings for block devices to be changed at runtime Kevin Wolf
2011-02-28 15:35 ` Stefan Hajnoczi
2011-02-28 15:48 ` Kevin Wolf
2011-03-01 9:55 ` Stefan Hajnoczi
2011-03-01 10:06 ` Kevin Wolf
2011-03-01 15:02 ` Chunqiang Tang
2011-03-01 13:03 ` Anthony Liguori
2011-03-01 13:22 ` Kevin Wolf
2011-03-01 15:47 ` Anthony Liguori [this message]
2011-03-01 12:42 ` Christoph Hellwig
2011-03-01 12:48 ` Stefan Hajnoczi
2011-03-01 12:50 ` Christoph Hellwig
2011-03-01 19:13 ` Anthony Liguori
2011-03-02 7:57 ` Kevin Wolf
2011-03-01 12:52 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6D151A.8080502@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aliguori@us.ibm.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=prerna@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.